Skip to content

Conversation

@AnshumanTripathi
Copy link

What type of PR is this?
/kind documentation

What this PR does / why we need it:
This PR updates the Release Notes Draft to k/k v1.35.0-rc.1

Which issue(s) this PR fixes:

Special notes for your reviewer:
This is an automated PR generated from krel The Kubernetes Release Toolbox

@k8s-ci-robot k8s-ci-robot added kind/documentation Categorizes issue or PR as related to documentation. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority labels Dec 10, 2025
@k8s-ci-robot k8s-ci-robot added area/release-team Issues or PRs related to the release-team subproject sig/release Categorizes an issue or PR as relevant to SIG Release. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Dec 10, 2025
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 10, 2025
Copy link
Member

@dipesh-rawat dipesh-rawat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would have expected to see the release notes for the following PR(s) included in the v1.35.0-rc.1 release notes. Could you please clarify if there’s a reason they aren’t listed, or if we might have missed something?

https://github.com/kubernetes/kubernetes/pull/135271
https://github.com/kubernetes/kubernetes/pull/135560
https://github.com/kubernetes/kubernetes/pull/135560
https://github.com/kubernetes/kubernetes/pull/135580
https://github.com/kubernetes/kubernetes/pull/135499
https://github.com/kubernetes/kubernetes/pull/135499
https://github.com/kubernetes/kubernetes/pull/135609

@dipesh-rawat
Copy link
Member

/assign @drewhagen

For final review and help with approving this as Release lead.

@AnshumanTripathi
Copy link
Author

I would have expected to see the release notes for the following PR(s) included in the v1.35.0-rc.1 release notes. Could you please clarify if there’s a reason they aren’t listed, or if we might have missed something?

https://github.com/kubernetes/kubernetes/pull/135271
https://github.com/kubernetes/kubernetes/pull/135560
https://github.com/kubernetes/kubernetes/pull/135560
https://github.com/kubernetes/kubernetes/pull/135580
https://github.com/kubernetes/kubernetes/pull/135499
https://github.com/kubernetes/kubernetes/pull/135499
https://github.com/kubernetes/kubernetes/pull/135609

Yeah I was unclear on this why krel did not pick them up. I am guessing because these dont have any docs related changes. Should I run the krel release notes process again to confirm? cc @Urvashi0109

@dipesh-rawat
Copy link
Member

I am guessing because these dont have any docs related changes. Should I run the krel release notes process again to confirm?

Just for some more context, these are the delta commits/PRs that landed after rc.0. I can see they already include release notes in their descriptions and also have the release note label. Therefore I expected them to appear in this draft. It might be useful to try generating the notes again to see if that resolves it, unless I have understood this incorrectly and the current output is already correct 😅

@AnshumanTripathi
Copy link
Author

All the above list PRs dont mention any required doc update in the PR description. Maybe I am missing something.

@Urvashi0109
Copy link
Contributor

I am guessing because these dont have any docs related changes. Should I run the krel release notes process again to confirm?

Just for some more context, these are the delta commits/PRs that landed after rc.0. I can see they already include release notes in their descriptions and also have the release note label. Therefore I expected them to appear in this draft. It might be useful to try generating the notes again to see if that resolves it, unless I have understood this incorrectly and the current output is already correct 😅

We will be adding missed PR manually here.

cc: @AnshumanTripathi

@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Dec 12, 2025
Copy link
Member

@sayanchowdhury sayanchowdhury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added punctuation to few of the PRs and the corresponsing json & markdown as suggestion

Signed-off-by: Anshuman Tripathi <anshuman.tripathi305@gmail.com>
Signed-off-by: Anshuman Tripathi <anshuman.tripathi305@gmail.com>
AnshumanTripathi and others added 4 commits December 12, 2025 09:00
Signed-off-by: Anshuman Tripathi <anshuman.tripathi305@gmail.com>
Signed-off-by: Anshuman Tripathi <anshuman.tripathi305@gmail.com>
Co-authored-by: Sayan Chowdhury <sayan.chowdhury2012@gmail.com>
Signed-off-by: Anshuman Tripathi <anshuman.tripathi305@gmail.com>
@AnshumanTripathi AnshumanTripathi force-pushed the release-notes-draft-v1.35.0-rc.1 branch from a97dd1b to b002b7d Compare December 12, 2025 17:00
Signed-off-by: Anshuman Tripathi <anshuman.tripathi305@gmail.com>
Copy link
Member

@sayanchowdhury sayanchowdhury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @AnshumanTripathi for the update. LGTM - I re-verified the git-log and it seems to list all the PRs merged between rc.0 and rc.1

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 12, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: AnshumanTripathi, kernel-kun, OrlinVasilev, sayanchowdhury, Urvashi0109
Once this PR has been reviewed and has the lgtm label, please ask for approval from drewhagen. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Urvashi0109
Copy link
Contributor

Hi @dipesh-rawat and @drewhagen , we have added missing PRs manually now. Need your PR review.🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/release-team Issues or PRs related to the release-team subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority sig/release Categorizes an issue or PR as relevant to SIG Release. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants