-
Notifications
You must be signed in to change notification settings - Fork 433
Update release notes draft to version v1.35.0-rc.1 #2925
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Update release notes draft to version v1.35.0-rc.1 #2925
Conversation
dipesh-rawat
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would have expected to see the release notes for the following PR(s) included in the v1.35.0-rc.1 release notes. Could you please clarify if there’s a reason they aren’t listed, or if we might have missed something?
https://github.com/kubernetes/kubernetes/pull/135271
https://github.com/kubernetes/kubernetes/pull/135560
https://github.com/kubernetes/kubernetes/pull/135560
https://github.com/kubernetes/kubernetes/pull/135580
https://github.com/kubernetes/kubernetes/pull/135499
https://github.com/kubernetes/kubernetes/pull/135499
https://github.com/kubernetes/kubernetes/pull/135609
|
/assign @drewhagen For final review and help with approving this as Release lead. |
Yeah I was unclear on this why krel did not pick them up. I am guessing because these dont have any docs related changes. Should I run the krel release notes process again to confirm? cc @Urvashi0109 |
Just for some more context, these are the delta commits/PRs that landed after rc.0. I can see they already include release notes in their descriptions and also have the release note label. Therefore I expected them to appear in this draft. It might be useful to try generating the notes again to see if that resolves it, unless I have understood this incorrectly and the current output is already correct 😅 |
|
All the above list PRs dont mention any required doc update in the PR description. Maybe I am missing something. |
We will be adding missed PR manually here. |
sayanchowdhury
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added punctuation to few of the PRs and the corresponsing json & markdown as suggestion
Signed-off-by: Anshuman Tripathi <anshuman.tripathi305@gmail.com>
Signed-off-by: Anshuman Tripathi <anshuman.tripathi305@gmail.com>
Signed-off-by: Anshuman Tripathi <anshuman.tripathi305@gmail.com>
Signed-off-by: Anshuman Tripathi <anshuman.tripathi305@gmail.com>
Co-authored-by: Sayan Chowdhury <sayan.chowdhury2012@gmail.com>
Signed-off-by: Anshuman Tripathi <anshuman.tripathi305@gmail.com>
a97dd1b to
b002b7d
Compare
Signed-off-by: Anshuman Tripathi <anshuman.tripathi305@gmail.com>
sayanchowdhury
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @AnshumanTripathi for the update. LGTM - I re-verified the git-log and it seems to list all the PRs merged between rc.0 and rc.1
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: AnshumanTripathi, kernel-kun, OrlinVasilev, sayanchowdhury, Urvashi0109 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Hi @dipesh-rawat and @drewhagen , we have added missing PRs manually now. Need your PR review.🙂 |
What type of PR is this?
/kind documentation
What this PR does / why we need it:
This PR updates the Release Notes Draft to k/k v1.35.0-rc.1
Which issue(s) this PR fixes:
Special notes for your reviewer:
This is an automated PR generated from
krel The Kubernetes Release Toolbox