Adding linter and unit test checks #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rootAvish
suggested changes
Mar 24, 2021
| uses: actions/setup-python@v2 | ||
| with: | ||
| python-version: '3.8' | ||
| - name: Run linter |
Contributor
There was a problem hiding this comment.
I've also used pydocstyle during development which enforces PEP357 (docstring validations). AFAIK pylint does not support that one so we need to run both tools in the linter, one for coding style and one for docstrings.
Also I'm okay with us switching to pylint but then you need to remove the pycodestyle dependency since it does the same thing essentially.
| @@ -0,0 +1,84 @@ | |||
| [MESSAGES CONTROL] | |||
|
|
|||
| disable=apply-builtin, | |||
Contributor
There was a problem hiding this comment.
Our maximum line length setting is 120 characters since 80 is too restrictive, can you also disable the 80 character check?
Contributor
There was a problem hiding this comment.
That standard is a carry-over from dependency analytics btw.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.