Fix scipen option not updating in R 4.2 via Rf_GetOption1 #2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In R 4.2,
Rf_GetOption1doesn't correctly reflect changes to thescipenoption, causingtest_format_options_state_changeto fail when format options are queried afteroptions(scipen = 10)is called.Changes
get_option("scipen")withparse_eval_global("getOption('scipen')")incurrent_format_options()getOption()instead of C API to retrieve scipen valueTechnical Context
R 4.2 lacks special handling for
scipeninRf_GetOption1that was added in later versions (r-source@7f20c19). Thedigitsoption works correctly via C API and doesn't require changes.Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
https://api.github.com/repos/posit-dev/ark/pulls/987/usr/bin/curl curl -s REDACTED /home/REDACTED/.rustup/toolchains/stable-x86_64-REDACTED-linux-gnu/lib/rustlib/x86_64-REDACTED-linux-gnu/lib/libmemchr-ff20d9e744b5ce29.rlib /home/REDACTED/.rustup/toolchains/stable-x86_64-REDACTED-linux-gnu/lib/rustlib/x86_64-REDACTED-linux-gnu/lib/libaddr2line-05ff42d0bb8bc056.rlib /home/REDACTED/.rustup/toolchains/stable-x86_64-REDACTED-linux-gnu/lib/rustlib/x86_64-REDACTED-linux-gnu/lib/libgimli-9e30a03d9a87a46b.rlib /home/REDACTED/.rustup/toolchains/stable-x86_64-REDACTED-linux-gnu/lib/rustlib/x86_64-REDACTED-linux-gnu/lib/libcfg_if-ca532f729409e986.rlib .5/src/lib.rs /home/REDACTED/.rustup/toolchains/stable-x86_64-REDACTED-linux-gnu/lib/rustlib/x86_64-REDACTED-linux-gnu/lib/libstd_detect-866c9680e50cd51f.rlib /home/REDACTED/.rustup/toolchains/stable-x86_64-REDACTED-linux-gnu/lib/rustlib/x86_64-u�� /home/REDACTED/.rustup/toolchains/stable-x86_64-REDACTED-linux-gnu/lib/rustlib/x86_64-REDACTED-linux-gnu/lib/librustc_std_workspace_alloc-2fb855ef27dbee02.rlib /home/REDACTED/.rustup/toolchains/stable-x86_64-REDACTED-linux-gnu/lib/rustlib/x86_64-REDACTED-linux-gnu/lib/libminiz_oxide-9b8400ec28816bfd.rlib /out�� known-linux-gnu/-D known-linux-gnu/XXH_PRIVATE_API= lib/rustlib/x86_64-REDACTED-linux-gnu/bin/gcc-ld/ld.lld hr-ff20d9e744b5ccc 2line-05ff42d0bb-m64 i-9e30a03d9a87a4/tmp/rustcSv7Q76/symbols.o lib/rustlib/x86_/tmp/cargo-installaZt5wy/release/build/cargo-nextest-2b9e5868b7b210db/build_script_build-2b9e5868b7b210db.build_script_build.68f1b9d09b5679f0-cgu.0.rcgu.o(http block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.