Support string method calls #134
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Technically, to be 100% compatible, this should be calling through a metatable assigned to all strings which has __index pointing to the string global table. This intermediate approach works for all sane use cases without requiring so much work. (It is not possible to *set* a metatable on a string in PUC-Lua, but it is at least possible to call `getmetatable` on a string and then mess with it.)
csnover
force-pushed
the
string-methods
branch
from
1966c51 to
acdea03
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Technically, to be 100% compatible, this should be calling through a metatable assigned to all strings which has __index pointing to the string global table. This intermediate approach works for all sane use cases without requiring so much work. (It is not possible to set a metatable on a string in PUC-Lua, but it is at least possible to call
getmetatableon a string and then mess with it.)