implement string.sub #67
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
This is related/dup-implementation of part of #36, however this handles strings as byte arrays, which corresponds with PUC-Rio Lua behavior |
Use saturating_add_signed to be safe
add out-of-bounds test for `j`
Fix `j` indexing
Fix `i == 0` case
Test `i == 0` case
- it has weird behavior on 32-bit architectures
... poking at stuff without a dev env is "*fun*"
Add Number test
- by casting from u64 (i64 and i64::MIN negated) -> usize, rather than i64 -> isize
forgot i used it for `select` impl...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to sub my strings, so I made a quick implementation