Skip to content

Conversation

@programmablereya
Copy link

This adds a simple Containerfile to run Tang within a Fedora-based container. In this PR, the image is not published anywhere, but it is built and tested. Also updates the README to remove the dead link to the external image.

Progress on #107.

I think for #107 to be closed, there would need to be a build of this that actually gets pushed to a container image repository. That is not the sort of thing I'm in a place to decide or set up credentials for y'all, but this should at least be a good start. :) I'd be happy to help with that PR assuming that the repository and credentials were decided and set up.

The podman endpoint tests don't add a constant to the random port number (I didn't understand why the other endpoint tests were doing this - isn't it already a random port number spanning the full range of user-accessible ports?) - let me know if that's something necessary for some reason or another.

@codecov
Copy link

codecov bot commented Jan 12, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 59.20%. Comparing base (83de399) to head (879b876).
⚠️ Report is 5 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #162      +/-   ##
==========================================
+ Coverage   58.44%   59.20%   +0.75%     
==========================================
  Files           4        4              
  Lines         580      576       -4     
  Branches      147      148       +1     
==========================================
+ Hits          339      341       +2     
+ Misses        140      135       -5     
+ Partials      101      100       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sarroutbi sarroutbi changed the title Add Containerfile for Podman/Docker. Add Containerfile for Podman/Docker Jan 12, 2026
This adds a simple Containerfile to run Tang within a Fedora-based container.
In this PR, the image is not published anywhere, but it is built and tested.
Also updates the README to remove the dead link to the external image.

Progress on latchset#107.
env:
DISTRO: ubuntu:noble
steps:
- uses: actions/checkout@v4
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I missed this from previous patch. Use latest checkout version:
actions/checkout@v6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants