-
Notifications
You must be signed in to change notification settings - Fork 64
Add Containerfile for Podman/Docker #162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
3d28dc8 to
879b876
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #162 +/- ##
==========================================
+ Coverage 58.44% 59.20% +0.75%
==========================================
Files 4 4
Lines 580 576 -4
Branches 147 148 +1
==========================================
+ Hits 339 341 +2
+ Misses 140 135 -5
+ Partials 101 100 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This adds a simple Containerfile to run Tang within a Fedora-based container. In this PR, the image is not published anywhere, but it is built and tested. Also updates the README to remove the dead link to the external image. Progress on latchset#107.
879b876 to
76053dc
Compare
| env: | ||
| DISTRO: ubuntu:noble | ||
| steps: | ||
| - uses: actions/checkout@v4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I missed this from previous patch. Use latest checkout version:
actions/checkout@v6
This adds a simple Containerfile to run Tang within a Fedora-based container. In this PR, the image is not published anywhere, but it is built and tested. Also updates the README to remove the dead link to the external image.
Progress on #107.
I think for #107 to be closed, there would need to be a build of this that actually gets pushed to a container image repository. That is not the sort of thing I'm in a place to decide or set up credentials for y'all, but this should at least be a good start. :) I'd be happy to help with that PR assuming that the repository and credentials were decided and set up.
The podman endpoint tests don't add a constant to the random port number (I didn't understand why the other endpoint tests were doing this - isn't it already a random port number spanning the full range of user-accessible ports?) - let me know if that's something necessary for some reason or another.