fix: use stable IDs for context identification instead of hash-based IDs #484
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cspath1
approved these changes
Jan 6, 2026
Contributor
cspath1
left a comment
cspath1
left a comment
There was a problem hiding this comment.
Thanks for implementing this! Really like this solution in general, but glad to see it's helping fix the issues mentioned.
Fixes issues where active context visual indicators (blue background) disappeared after editing and context edits reverted on page refresh. Contexts are now identified by their kind+key combination using getStableContextId(). - Remove generateContextId() and hash-based ID generation - Update ContextsProvider to use stable IDs for tracking active context - Sync context updates with LD SDK via ldClient.identify() - Remove deprecated areContextsEqual() in favor of stable ID comparison - Update all tests to reflect stable ID behavior
pranjal-jately-ld
force-pushed
the
pjately/fix-context-identification-with-stable-ids
branch
from
6425dde to
6ba9eec
Compare
pranjal-jately-ld
deleted the
pjately/fix-context-identification-with-stable-ids
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issues where active context visual indicators (blue background) disappeared after editing and contexts were being duplicated on page refresh/sharing URL . Contexts are now identified by their kind+key combination using getStableContextId().
Description
What does this PR do?
This PR fixes context identification to use stable IDs based on kind+key instead of hash-based IDs that include all properties. This resolves critical issues where:
Type of Change
Screenshots/Videos