fix: rename red palette to magenta and add true red palette #1189
+24
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Renamed existing red palette to magenta (pinkish-red hues) - Created new red palette based on #F91313 (notification error color) - Updated palette.ts to use magenta for error backgrounds - New red palette provides true red colors for error states Resolves layer5io#602 Signed-off-by: Jeet Burman <jeetburrman@gmail.com>
Author
|
@Rajesh-Nagarajan-11 @leecalcote @nebula-aac , I request a review. |
saurabhraghuvanshii
requested changes
Dec 13, 2025
| }; | ||
|
|
||
| export const red = { | ||
| export const magenta = { |
Contributor
There was a problem hiding this comment.
I think these are shades of Rose Red than magenta
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses issue #602 by renaming the existing red palette to magenta and introducing a new true red palette.
Resolves #602
Notes for Reviewers
This PR fixes #602
The existing
redpalette contained pinkish-magenta hues (e.g.,#ff385c,#FFB3B9). This has been renamed tomagentafor semantic accuracy. A newredpalette has been created using#F91313as the base color, which is already used for notification errors and provides true red colors.Changes are backward compatible - the magenta palette retains all the previous red values, and components using error states now benefit from more accurate red colors.
Signed commits