-
Notifications
You must be signed in to change notification settings - Fork 2
Nested SystemTypes: Add 'parent' to SystemType, update SystemType discovery, add tests #457
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: issue431_multiLibs
Are you sure you want to change the base?
Conversation
AntoineGautier
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@darenkeck-dev See my comments:
- The ES version should be updated if we want to use the
at()method. - The other one is more a question related to the requirement to organize templates by library.
|
@AntoineGautier changes have been made hiding any visible update in the client UI. This is ready for review again. |
07e0b44 to
2872fce
Compare
|
@darenkeck-dev Tests failed with 2872fce because of the following break in the JSON file path discovery:
I would be willing to remove this check from |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(I pushed a fix for stopping the discovery process after processing the root package.)
Regarding the changes from dk/455-nested-systemtypes, I tested loading two test packages with server/scripts/parse-test-package.ts and validated that configuration parameters specified in the UI are properly included in the payload with getSequenceData().
I also tested that dk/455-nested-systemtypes produces the same sequence document as the main branch for the same set of parameters.
Description
Server updates to support nested SystemTypes.
parentattribute to SystemTypeparentfieldClient
NOTE: no visible updates have been made in the client UI. This PR merges work to prepare for displaying nested templates and system type groups.
Related Issue(s)
#455
Testing
Tests have been updated on the server