feat: add qualifiers for Arg and Flag to disambiguate Cli.{Parsed.}Flag #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks to leanprover/lean4#5783, we now have recursive structure commands, which trips the inference into constructing a recursive struct. Therefore, we disambiguate the fields in `Cli.Parsed.Flag` to explicitly refer to `Cli.Flag`. Discovered when bumping toolchain to nightly in leanprover/LNSym#244.
bollu
force-pushed
the
adapt-to-recursive-structures
branch
from
d8545d4 to
0a0e103
Compare
Collaborator
|
This is already fixed on the nightly branch, which will be merged into main when 4.14.0-rc1 is released. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to leanprover/lean4#5783, we now have recursive structure commands,
which trips the inference into constructing a recursive struct. Therefore, we disambiguate the fields in
Cli.Parsed.Flagto explicitly refer toCli.Flag.Discovered when bumping toolchain to nightly in leanprover/LNSym#244.