feat: use static initializers where possible #12082
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the compiler produce C code that statically initializes close terms when possible. This change reduces startup time as the terms are directly stored in the binary instead of getting computed at startup.
The set of terms currently supported by this mechanism are:
Name.mkStrXand otherNamectors as they require special support due to their computed field and occur frequently due to name literals.In core there are currently 152,524 closed terms and of these 103,929 (68%) get initialized statically with this PR. The remaining 48585 ones are not extracted because they use (potentially transitively) various non trivial pieces of code like
stringToMessageDataetc. We might decide to add special support for these in the future but for the moment this feels like it's overfitting too much for core.