fix: work-around malformed all field in definitions
#14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some attributes like to_additive and to_dual create declarations which do not preserve the property that their `all` list is "a List of all (including this one) declarations in the same mutual block." The current thmeorem/def/opaque export logic relied on this being the case for all declarations. This fix ensures that the current "base" declaration is included in the list of names exported, and tries to ensure declarations are not re-exported by the appearance of malformed declarations, for example if: + declaration `x` has an `all` list `[x]`, and; + declaration `y` has an `all` list of `[x]` then the old/current logic would export `x` twice if it was found first; once for the `x` declaration, and again when exporting `y`. Ideally there would be an upstream change to try and ensure that this invariant is preserved, but the exporter should probably be made robust against this either way.
nomeata
changed the title
all field in definitions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some attributes like to_additive and to_dual create declarations which do not preserve the property that their
alllist is "a List of all (including this one) declarations in the same mutual block." The current theorem/def/opaque export logic relied on this being the case for all declarations.This fix ensures that the current "base" declaration is included in the list of names exported, and tries to ensure declarations are not re-exported by the appearance of malformed declarations, for example if:
xhas analllist[x], and;yhas analllist of[x]then the old/current logic would export
xtwice if thexdeclaration was found first; once for thexdeclaration, and again when exportingy.Ideally there would be an upstream change to try and ensure that this invariant is preserved, but the exporter should probably be made robust against this either way.