Use channelVersion objects instead of special permission ids #5622
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexVelezLl
requested changes
Jan 6, 2026
Member
AlexVelezLl
left a comment
AlexVelezLl
left a comment
There was a problem hiding this comment.
Thanks @taoerman! This is looking great! The only major concern is about the changes to the shared styles file!
Additionally, could you please address this comment within the scope of this PR? Thanks!
Comment on lines
+54
to
+59
| permissions.value = response.map(permission => ({ | ||
| id: permission.id, | ||
| description: permission.description, | ||
| distributable: permission.distributable, | ||
| })); | ||
| } |
Member
There was a problem hiding this comment.
I think we can just do permissions.value = response, right?
Comment on lines
+434
to
+437
| if (versionDetail.value?.id) { | ||
| return versionDetail.value.id; | ||
| } | ||
| return null; |
Member
There was a problem hiding this comment.
Here we can just do return versionDetail.value?.id; and it would have the same effect.
| @@ -1,5 +1,5 @@ | |||
| @import '~material-icons/iconfont/material-icons.css'; | |||
| @import '~kolibri-design-system/lib/styles/common'; | |||
| @import '~kolibri-design-system/lib/styles/definitions'; | |||
Member
There was a problem hiding this comment.
Seems like we have an unintended change here? 👀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Refactored special permissions loading to use channelVersionId instead of permissionIds.
References
Fixed #5617
Reviewer guidance
test manually