Clean up and modernize ledger-check #459
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shell-command with OUTPUT-BUFFER=t will insert the output after point in the current buffer, so point is not moved at all.
- Issue a user-error when attempting to jump to a nonexistent check buffer. - Pass BUFFER-OR-NAME directly to kill-buffer - Remove unused _buf variable
Previously, ledger-check-buffer was just getting its input from the default journal file (e.g., configured by ~/.ledgerrc). This has the unfortunate drawback of causing the errors reported by ledger to come from a file called "", which is a little confusing. Update ledger-report-visit-source to visit the marker's buffer rather than the file name, which is now wrong.
This gives several advantages by default: 1. Keys that normally insert characters are unbound, rather than triggering a buffer-read-only error. 2. The buffer is read-only by default. 3. special-mode has useful key bindings for report-like buffers.
Rather than forcibly shrinking the window, pass the appropriate actions to pop-to-buffer to allow the user to override the display behavior.
There's no behavior difference with the conditional because the removed capture group would have always matched and returned non-nil (but the match may have been empty).
Collaborator
Author
|
Marking this PR as a draft because I'd like to discuss in #450 whether we should |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
says
special-mode