LightGCN: break item scoring into batches #982
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #982 +/- ##
=======================================
Coverage 88.96% 88.96%
=======================================
Files 218 218
Lines 15089 15095 +6
=======================================
+ Hits 13424 13430 +6
Misses 1665 1665 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mdekstrand
force-pushed
the
feature/gcn-batch-infer
branch
from
1402085 to
a2d3084
Compare
Member
Author
|
This does not seem to reduce memory usage, and significantly increases recommendation time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This breaks item scoring in LightGCN into batches to reduce the inference-time memory requirements due to copied tensors.