Skip to content

Conversation

@sushobhan2024
Copy link
Contributor

As we discussed, I --

  1. removed DecomposedMetric class,
  2. kept only measure_run method in GlobalMetric class, and avoided extending Metric class.

@codecov
Copy link

codecov bot commented Jan 22, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.14%. Comparing base (61dc1b4) to head (cb59d1a).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #983      +/-   ##
==========================================
+ Coverage   88.96%   89.14%   +0.17%     
==========================================
  Files         218      218              
  Lines       15089    15012      -77     
==========================================
- Hits        13424    13382      -42     
+ Misses       1665     1630      -35     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sushobhan2024 sushobhan2024 marked this pull request as draft January 22, 2026 20:01
@sushobhan2024 sushobhan2024 marked this pull request as ready for review January 23, 2026 20:00
@mdekstrand mdekstrand self-requested a review January 23, 2026 20:14


class GiniBase(DecomposedMetric, RankingMetricBase):
class GiniBase(RankingMetricBase):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does RankingMetricBase inherit from ListMetric? Gini is not a listwise metric, so if it does then we should either:

  • Make RankingMetricBase no longer inherit from ListMetric, and update all the ranking metrics that are listwise metrics to inherit from both RankingMetricBase and ListMetric.
  • Rename RankingMetricBase to RankingListMetricBase and make GiniBase no longer inherit from RankingMetricBase
  • A combination of the two: introduce RankingListMetricBase to be both ranking metric and list metric, and make the other metrics inherit from it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants