Fix thread-safety: remove static from local variables #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The f2c-translated C code had static local variables in multiple functions (setulb_, mainlb_, and 18+ other subroutines), making them non-thread-safe. Static variables are shared across all function calls, causing race conditions, memory corruption, and segmentation faults in multi-threaded contexts. This commit removes the static keyword from 202 local variable declarations, making each function call have its own independent local state on the stack. Only legitimate static uses (constant definitions and format strings) are preserved. This enables true thread-safety without requiring mutex serialization.
yannrichet
added a commit
to libKriging/libKriging
that referenced
this pull request
Dec 9, 2025
Use the fixed version of lbfgsb_cpp that removes static local variables to enable true thread-safety. This eliminates the need for mutex serialization in the optimizer. Related PRs: - yannrichet/lbfgsb_cpp#3 - libKriging/lbfgsb_cpp#6
hpwxf
reviewed
Dec 11, 2025
Member
hpwxf
left a comment
hpwxf
left a comment
There was a problem hiding this comment.
J’y jette un œil complémentaire asap.
| const int* iprint, char* csave, | ||
| bool* lsave, int* isave, double* dsave, | ||
| std::size_t len_task, std::size_t len_csave | ||
| ftnlen len_task, ftnlen len_csave |
Member
There was a problem hiding this comment.
Dans quel cas as-tu besoin de changer le type associé à la taille ?
| namespace lbfgsb { | ||
| extern "C" { | ||
| void setulb_( | ||
| int setulb_( |
Member
There was a problem hiding this comment.
D’où vient le besoin du retour en int ?
| "\002,/,\002 2 rounding errors dominate computat" | ||
| "ion.\002)"; | ||
| static char fmt_9015[] = "(/,\002 Warning: more than 10 function and gr" | ||
| char fmt_9015[] = "(/,\002 Warning: more than 10 function and gr" |
Member
There was a problem hiding this comment.
J’ai l’impression que beaucoup de variables statiques avec une telle valeur par défaut pourraient être passées en « static const » ou juste « const » (meilleur pour les perfs et la safety)
|
Désolé, c'est l'autre PR qu'il faut regarder :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The f2c-translated C code had static local variables in multiple functions (setulb_, mainlb_, and 18+ other subroutines), making them non-thread-safe.
Static variables are shared across all function calls, causing race conditions, memory corruption, and segmentation faults in multi-threaded contexts.
This commit removes the static keyword from 202 local variable declarations, making each function call have its own independent local state on the stack. Only legitimate static uses (constant definitions and format strings) are preserved.
This enables true thread-safety without requiring mutex serialization.
Testing:
Related: