Try compat with multistart (thread-safe) and fix some type (for CRAN warning) #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: yannrichet-asnr <148193180+yannrichet-asnr@users.noreply.github.com>
Fix LTO type mismatch warning for setulb_ function declaration
The f2c-translated C code had static local variables in multiple functions (setulb_, mainlb_, and 18+ other subroutines), making them non-thread-safe. Static variables are shared across all function calls, causing race conditions, memory corruption, and segmentation faults in multi-threaded contexts. This commit removes the static keyword from 202 local variable declarations, making each function call have its own independent local state on the stack. Only legitimate static uses (constant definitions and format strings) are preserved. This enables true thread-safety without requiring mutex serialization.
Fix thread-safety: remove static from local variables
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.