fix(quic): Identify /quic as QUIC address
#3288
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Identify multiaddress with `/quic` (draft 29) as QUIC address in case `support_draft_29` is `true`. Without this patch the Rust punchr client would discard any QUIC addresses with `/quic` in its `Transport::address_translation`. Thus `/quic` based observed addresses from `libp2p-identify` would not be added to the local set of external addresses and thus QUIC would not be available as a transport for hole punching.
elenaf9
approved these changes
Jan 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Identify multiaddress with
/quic(draft 29) as QUIC address in casesupport_draft_29istrue.Without this patch the Rust punchr client would discard any QUIC addresses with
/quicin itsTransport::address_translation. Thus/quicbased observed addresses fromlibp2p-identifywould not be added to the local set of external addresses and thus QUIC would not be available as a transport for hole punching.Notes
Links to any relevant issues
#3151 introduced draft-29 support.
Open Questions
Change checklist
A changelog entry has been made in the appropriate cratesNot necessary as it hasn't yet been released.