feat(peer-store): Remove addresses from peer store on dial failure #5926
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jxs
reviewed
Mar 11, 2025
Member
jxs
left a comment
jxs
left a comment
There was a problem hiding this comment.
Thanks Daniel! Overall LGTM, left a comment.
elenaf9
reviewed
Mar 12, 2025
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
elenaf9
reviewed
Mar 18, 2025
dknopik
force-pushed
the
peer-store-remove-undialable
branch
from
2c8f8f9 to
aa7c0c4
Compare
Collaborator
Author
|
Pushed a new version that:
The only open question from my perspective is whether to reintroduce the "permanent address" mechanism as seen here: 2c8f8f9 EDIT: discussed in call - we'll differentiate by origin ( |
elenaf9
reviewed
Mar 28, 2025
Co-authored-by: Elena Frank <elena.frank@protonmail.com>
dknopik
force-pushed
the
peer-store-remove-undialable
branch
from
a731633 to
5184663
Compare
drHuangMHT
reviewed
Apr 1, 2025
elenaf9
previously approved these changes
Apr 11, 2025
mergify
bot
dismissed
elenaf9’s stale review
Approvals have been dismissed because the PR was updated after the send-it label was applied.
…to peer-store-remove-undialable
jxs
approved these changes
Apr 11, 2025
Member
jxs
left a comment
jxs
left a comment
There was a problem hiding this comment.
Thanks fr the patience Daniel! ❤️
4 tasks
mergify bot
pushed a commit
that referenced
this pull request
Apr 30, 2025
Refactor the events emitted by the `peer_store::Behavior`: 1. Merge the current 3 event types (`behavior::Event`, `store::Event`, `memory_store::Event`) into a single type that is emitted by the `Store` implementation. 2. Use more descriptive event variants `AddressAdded`, `AddressRemoved` that also expose the specific `Multiaddr`. 3. Remove `Event::CustomDataUpdate` variant. Discussed in #5926 (comment) and #5926 (comment). Pull-Request: #6011.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When the
MemoryStorereceives aFromSwarm::DialFailureevent, it will now modify the store appropriately:LocalPeerId: Remove the peer from the store.WrongPeerId: Remove the address for the dialed peer ID and readd it for the received peer ID.Transport: Remove the failed addresses from the store.Furthermore, we group some repeated event logic in a new function
push_event_and_wakefor internal use.Follow-up to #5724
Notes & open questions
None.
Change checklist