fix updating nodes during update loop #687
Conversation
|
Fixes #670 |
|
There's an issue with this fix as it does not go through the vrt till the end. |
wouterlucas
left a comment
wouterlucas
left a comment
There was a problem hiding this comment.
Is your initial creation out of bounds and is it not being processed correctly before you put it on screen?
| updateType &= ~UpdateType.RenderBounds; // remove render bounds update | ||
| return; | ||
| } | ||
|
|
There was a problem hiding this comment.
Why are we removing this? This will force part of the tree that are out of bounds to continue to be processed, which essentially is wasteful as those parts aren't visible (hence take performance).
There was a problem hiding this comment.
This snippit makes lines 1271 unreachable. TS warns about it you're just using this.renderState rather than renderState. This prevents nodes from updating that were out of bounds and coming into bounds.
|
|
||
| // reset update type | ||
| this.updateType = 0; | ||
| this.childUpdateType = 0; |
There was a problem hiding this comment.
How does this help exactly?
3 participants
Resetting update type should be done at top of the loop as nodes can change values during the render cycle and can be redrawn on the next frame.