Disable electrum-client default features
#285
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RUSTSEC-2024-0336 pertains older versions of `rustls` that were used by our dev depedency `electrum-client` in v0.15.1. As we're blocked from upgrading until LDK supports `rust-bitcoin` 0.31, and we don't use TLS in tests anyways, we just disable the default features for now. We will have to re-enable them once we actually use Electrum syncing though.
Collaborator
Author
|
Unfortunately this doesn't work as our tests require |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #283.
RUSTSEC-2024-0336 pertains older versions of
rustlsthat were used by our dev depedencyelectrum-clientin v0.15.1.As we're blocked from upgrading until LDK supports
rust-bitcoin0.31, and we don't use TLS in tests anyways, we just disable the default features for now. We will have to re-enable them once we actually use Electrum syncing though.