Update to 0.2.0 and minor tweaks #141
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 Thanks for assigning @valentinewallace as a reviewer! |
Closed
Contributor
|
CI sad |
Contributor
Author
|
Cause ldk 0.2 isn't uploaded yet :) |
TheBlueMatt
changed the title
TheBlueMatt
force-pushed
the
main
branch
3 times, most recently
from
7c8461b to
009a548
Compare
Naively update to LDK 0.2 using the sync wrappers to keep current behavior.
TheBlueMatt
changed the title
TheBlueMatt
force-pushed
the
main
branch
3 times, most recently
from
5dfcae9 to
3ca27b5
Compare
With LDK 0.2, most traits now offer async variants. In the previous commit we ignored these but here we migrate to them everywhere except in the `ChannelMonitor` persistence. Note that we have to switch to async stdin reading in cli.rs to ensure we always reach an `await` point in a timely manner on all tasks.
TheBlueMatt
force-pushed
the
main
branch
5 times, most recently
from
29c4033 to
e0ad51d
Compare
Now that we have `ChainMonitor::load_existing_monitor` we can use it during startup to avoid the excess persistence at startup.
Its always been a bit strange that we persist the addresses of our peers to disk when there's a public gossip db, its not really a thing most LN nodes do. It might be useful for private channels but there's not a lot of reason to have it in `ldk-sample`.
Contributor
|
I'm good with a squash. Also Windows CI is sad |
|
🔔 1st Reminder Hey @valentinewallace! This PR has been waiting for your review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.