Skip to content

workflow: replace swapserverrpc in lit-setup #1061

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hieblmi merged 1 commit into from
Dec 17, 2025
Merged

workflow: replace swapserverrpc in lit-setup #1061

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/actions/lit-setup/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ runs:
run: |
go mod edit -replace=github.com/lightninglabs/loop=../
go mod edit -replace=github.com/lightninglabs/loop/looprpc=../looprpc
go mod edit -replace=github.com/lightninglabs/loop/swapserverrpc=../swapserverrpc
Comment on lines 22 to +23
Copy link

@gemini-code-assist gemini-code-assist bot Dec 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Now that there are multiple sub-modules being replaced, you could improve maintainability by refactoring these repeated go mod edit -replace commands into a loop. This would make it easier to add or remove sub-module replacements in the future.

For example:

for mod in looprpc swapserverrpc; do
  go mod edit -replace="github.com/lightninglabs/loop/$mod=../$mod"
done

Copy link
Collaborator

@starius starius Dec 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

looprpc should also be replaced.

Copy link
Collaborator

@hieblmi hieblmi Dec 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its already replaced in the line above.

go mod tidy
shell: bash

Expand Down