Restrict first and last name input fields to be more than 1 characters and to no #493
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s and to not contain digits (#22563) ## Reason closes PX-1302 Yellowcard does not allow names containing numbers, and I can't really think of a reason we should either? GitOrigin-RevId: e6fc9162d884d82256e3ee71c8330edeebb53983
Contributor
Author
|
The following public packages have changed files:
There are no existing changesets for this branch. If the changes in this PR should result in new published versions for the packages above please add a changeset. Any packages that depend on the planned releases will be updated and released automatically in a separate PR. Each changeset corresponds to an update in the CHANGELOG for the packages listed in the changeset. Therefore, you should add a changeset for each noteable package change that this PR contains. For example, if a PR adds two features - one feature for packages A and B and one feature for package C - you should add two changesets. One changeset for packages A and B and one changeset for package C, with a description of each feature. The feature description will end up being the CHANGELOG entry for the packages in the changeset. No releases planned. Last updated by commit bed9431 |
…… (#22867) …haracters and to not contain digits (#22563)" This reverts commit e6fc9162d884d82256e3ee71c8330edeebb53983. ## Reason there's an issue where sign up in mx is blocked, reverting this to be safe GitOrigin-RevId: 6ead3d065fd639bd7f7f1e309450801d0f794a90
## Reason The sparkcore vs paycore ent searches is kind of frustrating because it doesn't indicate if it exists in one or the other. So I wanted to combine both into a single search so you don't have to toggle the schema manually (and it'll show results for both schemas) ## Overview - deletes old searches for sparkcore and paycore - queries both schemas for results in new unified search input - search types are combined (defaults to auto if it doesn't exist for one of the schemas) - shows the schema on the actual ent! ## Test Plan works locally   <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **New Features** * Unified search input consolidates results across schemas and shows schema on results. * CardPage header supports custom right-side content (used to show schema badges). * **Refactor** * Replaced two specialized search inputs with a single unified one for consistent behavior. * Inspector now uses a single link component for entity navigation for consistent styling. * **Chores** * Removed legacy per-schema search components and related query wiring. <sub>✏️ Tip: You can customize this high-level summary in your review settings.</sub> <!-- end of auto-generated comment: release notes by coderabbit.ai --> GitOrigin-RevId: 7ae439a34e2c04d40bf2163190a78179dfbf000a
## Reason This change fixes a bug in the `CodeInput` component (unified variant) where clicking in the middle of the input would place the cursor at that arbitrary position, preventing users from easily completing the code. ## Overview An `onMouseDown` handler has been added to the `UnifiedCodeInputContainer`. This handler intercepts clicks and, if the click occurs on an input position *after* the first empty one, it prevents the default focus behavior and redirects focus to the first available empty input field. If all inputs are filled, it focuses the last input. ## Test Plan - All existing tests pass. - Two new test cases have been added to `js/apps/examples/ui-test-app/src/tests/CodeInput.test.tsx` to specifically cover: - Redirecting focus to the first empty input when clicking on a later input. - Allowing normal focus when clicking on or before the first empty input. - Lint checks passed. --- [Slack Thread](https://lightsparkgroup.slack.com/archives/C0447HDL3LY/p1767211308856809?thread_ts=1767211308.856809&cid=C0447HDL3LY) <a href="https://cursor.com/background-agent?bcId=bc-5bceb9c9-4f25-4715-b3d7-d56146281eed"><picture><source media="(prefers-color-scheme: dark)" srcset="https://cursor.com/open-in-cursor-dark.svg"><source media="(prefers-color-scheme: light)" srcset="https://cursor.com/open-in-cursor-light.svg"><img alt="Open in Cursor" src="https://cursor.com/open-in-cursor.svg"></picture></a> <a href="https://cursor.com/agents?id=bc-5bceb9c9-4f25-4715-b3d7-d56146281eed"><picture><source media="(prefers-color-scheme: dark)" srcset="https://cursor.com/open-in-web-dark.svg"><source media="(prefers-color-scheme: light)" srcset="https://cursor.com/open-in-web-light.svg"><img alt="Open in Web" src="https://cursor.com/open-in-web.svg"></picture></a> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **New Features** * Added a configurable autoFocus option for modals (defaults to enabled); specific modals can opt out. * **Bug Fixes** * Improved unified code-input focus behavior: clicking empty areas redirects to the first empty input; clicks on filled inputs preserve focus; when all inputs are filled, focus stays on the last. * **Tests** * Added tests for unified code-input focus behavior covering empty, partially filled, and all-empty scenarios. <sub>✏️ Tip: You can customize this high-level summary in your review settings.</sub> <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Co-authored-by: Cursor Agent <cursoragent@cursor.com> Co-authored-by: Brian Siao Tick Chong <bsiaotickchong@gmail.com> Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> GitOrigin-RevId: ac96b2361390be252d2bfb994cce33852571c499
## Reason small fixes for tazapay link bank screen ## Overview - adds description to tazapay link bank screen - removes unused info icon from accountNumber input - fixes bank icon ## Test Plan  <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **New Features** * Added multilingual descriptions for bank linking flow with support for English, Spanish, Portuguese, German, French, Italian, and other languages. * **Bug Fixes** * Removed unnecessary icon from account number input field. * **Style** * Updated bank icon to solid design throughout the bank linking interface. <sub>✏️ Tip: You can customize this high-level summary in your review settings.</sub> <!-- end of auto-generated comment: release notes by coderabbit.ai --> GitOrigin-RevId: 1e5f3efad1862c652b919583644e25b30439667f
…#22913) ## Reason closes PX-1310 Add Zambia as a YC integration. Zambia uses the Kwacha (ZMW) so add that as well 90% of this PR is files updated by adding ZMW currency ## Test go through onboarding flow for Zambian users <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **New Features** * Zambian Kwacha (ZMW) added across the platform and APIs. * Yellow Card onboarding now supports Zambia (ZMW) as an account option, including Zambia-specific mobile network choices and phone validation/masked display. * Feature gate introduced to control staged rollout of Yellow Card Zambia onboarding. <sub>✏️ Tip: You can customize this high-level summary in your review settings.</sub> <!-- end of auto-generated comment: release notes by coderabbit.ai --> GitOrigin-RevId: ffc4b510f63c9e5bbaed4ae9bcbba24be0a9a8f3
…login and create account content (#22814) ## Reason Fixes mobile cta buttons to bottom of bridge card form, and centers login and create account content. This will help prevent adding fixed heights such that the button is either too low or too high on the screen ## Overview - adds parameters to BridgeCardForm to handle centering content and fixing cta content to the bottom of the screen ## Test Plan Tested all onboarding flows manually   GitOrigin-RevId: 83b42641cfe9dc65f2521a3b6b4ef7776f79d30d
Adding filtering by payment hash per request from Chivo: <img width="1500" height="1342" alt="Screenshot 2026-01-12 at 1 59 30 PM" src="https://github.com/user-attachments/assets/b7b888a6-90c5-4367-86a3-edcb5e731307" /> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **New Features** * Added a "Payment Hash" column to Transactions and a "Payment Hash" string filter (64-character hex) to search and filter transactions by payment hash. * **Style** * Consolidated filter action button layout into a shared component for consistent spacing, wrapping, and max-width across table filters. <sub>✏️ Tip: You can customize this high-level summary in your review settings.</sub> <!-- end of auto-generated comment: release notes by coderabbit.ai --> GitOrigin-RevId: 5c51f07e6a4bc347492fafd60e38aacb0a6cc107
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
![https://cursor.com/open-in-cursor-dark.svg"><source](https://cursor.com/open-in-cursor-dark.svg"><source){kind=link}
![https://cursor.com/open-in-cursor-light.svg"><img](https://cursor.com/open-in-cursor-light.svg"><img){kind=link}
![https://cursor.com/open-in-cursor.svg"></picture></a> <a](https://cursor.com/open-in-cursor.svg"></picture></a> <a){kind=link}
![https://cursor.com/open-in-web-dark.svg"><source](https://cursor.com/open-in-web-dark.svg"><source){kind=link}
![https://cursor.com/open-in-web-light.svg"><img](https://cursor.com/open-in-web-light.svg"><img){kind=link}
![https://cursor.com/open-in-web.svg"></picture></a](https://cursor.com/open-in-web.svg"></picture></a){kind=link}
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If this change should result in new package versions please add a changeset before merging. You can do so by clicking the link provided by changeset bot below.