feat: split tests of query.max_query_count
#670
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexislefebvre
force-pushed
the
feat-split-tests-of-query.max_query_count
branch
3 times, most recently
from
68c692a to
6171afd
Compare
alexislefebvre
force-pushed
the
feat-split-tests-of-query.max_query_count
branch
from
6171afd to
0c3a63e
Compare
alexislefebvre
commented
Dec 11, 2025
| private function getMaxQueryAnnotation(): ?int | ||
| { | ||
| if (Kernel::MAJOR_VERSION >= 7) { | ||
| trigger_error('The annotationReader is not available and it can’t be enabled on Symfony 7+, @QueryCount is not supported', \E_USER_WARNING); |
Collaborator
Author
There was a problem hiding this comment.
Providing this information is better than before, but this warning may not appear when running tests, so it may be ineffective.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes GH-606
Split from:
TODO:
QueryCounterso that it doesn’t fail if the annotation reader is not available,query.max_query_countshould work on Symfony 7+ even without the support for annotations. Show a warning instead if the annotation can’t be read? The bundle need to the annotation reader to check if an@QueryCount(x)annotation was actually used…QueryCountto replace the annotation on the long termUpdate:
testAllowedQueriesExceededExceptionworked because ofquery.max_query_count: 0, not because of the annotation. It was a false positive since e2fdc70 from