Skip to content

Conversation

@nabijaczleweli
Copy link

@nabijaczleweli nabijaczleweli commented Nov 2, 2021

False negative in the test, nbd

@keszybz
Copy link

keszybz commented Nov 17, 2021

I think should be conditionalized on rust version. With rust 1.54.0 this test now fails.

@nabijaczleweli
Copy link
Author

nabijaczleweli commented Nov 17, 2021

Yeah, fair. cfg(version) is experimental, so I effectively inlined the rustc_version crate, and pick the old path before rustc 1.55

@keszybz
Copy link

keszybz commented Nov 18, 2021

I tested this with rust-1.54.0-1.fc33.x86_64 and cargo-1.56.1-1.fc33.x86_64 and the tests pass in both cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants