Make Instruction implement Clone #25
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_reference_casting) It is a zero-cost abstraction, so there is no additional overhead or performance hit.
Use UnsafeCell for char_buf to make modern Rust linter happy (invalid…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Storing an Instruction instead of, say, a String, is very useful. The only thing missing was Clone that I often need working with nom (the parser combinator library).
I have no idea yet if both Instruction and IC (necessary to implement Clone for Instruction) are Clone-compatible (please tell me!). I will test this soon anyway. It has no effect on crate tests passing or not.
I also had to merge romazu's commit to compile the project without downgrading rustc.