Frontend code challenge #2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enoxlaalu
commented
Nov 4, 2024
Enoxlaalu
commented
- added design and info to SymbolCard, added dumb components inside it
- added shadow and shake animation to SymbolCard
- improved performance of SymbolCard by adding components and memoizing…
- made chart and cards layout responsive on mobile and desktop
- added logic for showing and hiding info in cards
- added suspense to router and fixed responsive design
- put shadow and effect states in separate custom hooks
- added formatting of the currency for VolumeLabel
- Made active card id to be saved to localStorage
- fixed folder structure
- fixed race condition in price chart
- fixed trends and symbolCard performance
- fixed bad behavior of active item from localstorage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.