Don't fail parsing when source has unknown fields #381
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Specifically for fontinfo.plist. The unknown fields will be ignored (and dropped) but I don't think it's worthwhile for us to fail to parse an otherwise well-formed input in this case. (This is motivated by a real-world failure, https://github.com/cadsondemak/itim/blob/2e586046/sources/Itim-Regular.ufo/fontinfo.plist).
anthrotype
approved these changes
Nov 27, 2025
Collaborator
anthrotype
left a comment
anthrotype
left a comment
There was a problem hiding this comment.
same here, would be nice to get a warning at least (unless it's too complicated with serde?)
Member
Author
|
norad doesn't have logging, and i'm not super inclined to add that just for this.. |
Member
Author
|
actually nevermind I've added logging support for #382, but won't log here because it's internal to serde... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specifically for fontinfo.plist. The unknown fields will be ignored (and dropped) but I don't think it's worthwhile for us to fail to parse an otherwise well-formed input in this case.
(This is motivated by a real-world failure,
https://github.com/cadsondemak/itim/blob/2e586046/sources/Itim-Regular.ufo/fontinfo.plist).