Fix: Allow async updates/deletes to the Stack #187
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…an state Observed the following sequence: 1) Create long-running stack create 2) During CREATE_IN_PROGRESS, delete k8s Stack 3) Delete timestamps got added, no deleteStack call made to AWS 4) Stack completed 5) Operator stopped following, but left resource as CREATE_IN_PROGRESS The problem was in updates being performed to an out-of-date object handle (in the follower). Now, it fetches a fresh object (cached) for the latest version we have. This will give it more opportunity to work itself out. See also: https://github.com/cuppett/cloudformation-operator/pull/1#discussion_r601849772
…ted by hand in AWS Signed-off-by: Stephen Cuppett <steve@cuppett.com>
Contributor
Author
|
@linki you'll probably want this one before creating a 0.9 |
|
Tested the PR and it worked as expected 👍🏼 @linki you should definitively merge it. |
Signed-off-by: Stephen Cuppett <steve@cuppett.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was found by @yasseur1007 that deletes initiated while the stack was still being followed would get dropped. Also, if a stack was deleted on the AWS side, no attempt to reconcile/recreate would be possible. This PR resolves both of those.
Also, created an example which makes a CloudFront CDN in the samples directory. Added that and made one, combined S3 example getting ready for clean inclusion in samples for OLM CSV.