Skip to content

Make all readonly fields public #159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
konard wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Make all readonly fields public #159

konard wants to merge 3 commits into from

Conversation

@konard
Copy link
Member

@konard konard commented Sep 13, 2025 •
edited
Loading

Summary

  • Made all readonly fields public across the codebase as requested in issue Make all readonly fields public #120
  • Updated access modifiers from protected or private to public for readonly fields in:
    • ListFiller<TElement, TReturnConstant>: _list and _returnConstant fields
    • SetFiller<TElement, TReturnConstant>: _set and _returnConstant fields
    • ArrayFiller<TElement>: _array field
    • ArrayFiller<TElement, TReturnConstant>: _returnConstant field
    • ArrayPool<T>: _maxArraysPerSize and _pool fields
    • AllSegmentsWalkerBase<T, TSegment>: _minimumStringSegmentLength field
    • DictionaryBasedDuplicateSegmentsWalkerBase<T, TSegment>: _resetDictionaryOnEachWalk field
    • BitString: _bitsSetIn16Bits static field

Test plan

  • All existing tests pass successfully
  • No breaking changes introduced
  • Fields maintain their readonly nature, only access level changed

🤖 Generated with Claude Code

Resolves #120

@konard
Initial commit with task details for issue #120
2ac7b8e 
Adding CLAUDE.md with task information for AI processing.
This file will be removed when the task is complete.

Issue: #120
@konard konard self-assigned this Sep 13, 2025
@konard @claude
Make all readonly fields public
3a91fd8 
Updated access modifiers for readonly fields from protected/private to public across multiple classes:
- ListFiller: _list and _returnConstant fields
- SetFiller: _set and _returnConstant fields
- ArrayFiller classes: _array and _returnConstant fields
- ArrayPool: _maxArraysPerSize and _pool fields
- Segment walker classes: _minimumStringSegmentLength and _resetDictionaryOnEachWalk fields
- BitString: _bitsSetIn16Bits field

All tests pass successfully after these changes.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
@konard konard changed the title [WIP] Make all readonly fields public Make all readonly fields public Sep 13, 2025
@konard konard marked this pull request as ready for review September 13, 2025 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@konard konard

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Make all readonly fields public

2 participants

@konard