Skip to content

Rename directory parameter to path in DeleteAll methods #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
konard wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Rename directory parameter to path in DeleteAll methods #95

konard wants to merge 4 commits into from

Conversation

@konard
Copy link
Member

@konard konard commented Sep 13, 2025 •
edited
Loading

Summary

  • Rename 'directory' parameter to 'path' in all DeleteAll method overloads in both C# and C++ FileHelpers
  • Update XML documentation to reflect parameter name changes
  • Simplified documentation comments as suggested in the issue

Changes Made

  • C# FileHelpers.cs: Renamed directory parameter to path in three DeleteAll method overloads
  • C++ FileHelpers.h: Updated corresponding C++ method signatures to use path parameter
  • Documentation: Updated all XML documentation comments to reference the new parameter name

Test Plan

  • Build succeeded without errors
  • All existing tests pass
  • Parameter naming now aligns with .NET Directory.EnumerateFiles convention

Fixes #52

🤖 Generated with Claude Code

@konard
Initial commit with task details for issue #52
2c738c4 
Adding CLAUDE.md with task information for AI processing.
This file will be removed when the task is complete.

Issue: #52
@konard konard self-assigned this Sep 13, 2025
konard and others added 2 commits September 13, 2025 18:09
@konard @claude
Rename directory parameter to path in DeleteAll methods
217221c 
Rename 'directory' parameter to 'path' in DeleteAll method overloads to follow .NET naming conventions for Directory.EnumerateFiles, and update XML documentation accordingly. This aligns with the standard .NET API parameter naming as specified in the Directory.EnumerateFiles documentation.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
@konard @claude
Update C++ FileHelpers to use path parameter in DeleteAll methods
ac0aa4e 
Update parameter name from 'directory' to 'path' in C++ FileHelpers to match the C# implementation and .NET naming conventions.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
@konard konard changed the title [WIP] Rename directory argument Rename directory parameter to path in DeleteAll methods Sep 13, 2025
@konard konard marked this pull request as ready for review September 13, 2025 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@konard konard

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Rename directory argument

2 participants

@konard