Skip to content

Create CLink concept #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
konard wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Create CLink concept #124

konard wants to merge 3 commits into from

Conversation

@konard
Copy link
Member

@konard konard commented Sep 10, 2025 •
edited
Loading

Summary

  • Implements the CLink concept as requested in issue Create CLink concept #102
  • Provides a C++20 concept that defines a link-like interface with required members
  • Adds comprehensive testing to verify the implementation

Implementation Details

CLink Concept

The CLink concept requires types to have:

  • bool empty() method - checks if the link is empty
  • value_type member type - defines the type of values stored in begin/end
  • value_type begin member - start of the link range
  • value_type end member - end of the link range

Files Added/Modified

  • cpp/Platform.Interfaces/CLink.h - New concept definition and helper struct
  • cpp/Platform.Interfaces/Platform.Interfaces.h - Added includes for CLink.h and CLinkAddress.h
  • examples/test_clink.cpp - Comprehensive test suite with both positive and negative test cases

Design Decisions

  • Follows existing codebase patterns (similar to CEnumerable, CArray, etc.)
  • Uses C++20 concepts with requires clauses for clear interface specification
  • Provides a Link<T> helper struct for type trait access
  • Includes compile-time and runtime tests to ensure correctness

Test Plan

  • Created test cases that verify types satisfying the concept work correctly
  • Created test cases that verify types NOT satisfying the concept fail compilation
  • Verified runtime behavior of concept-satisfying types
  • Confirmed successful compilation with GCC C++20
  • All tests pass successfully

Related Issues

Fixes #102

🤖 Generated with Claude Code

@konard
Initial commit with task details for issue #102
8f4de99 
Adding CLAUDE.md with task information for AI processing.
This file will be removed when the task is complete.

Issue: #102
@konard konard self-assigned this Sep 10, 2025
konard and others added 2 commits September 10, 2025 18:24
@konard
Remove CLAUDE.md - PR created successfully
e75bde7
@konard @claude
Implement CLink concept with required interface
fe46328 
- Created CLink.h with concept definition requiring:
  - bool empty() method
  - value_type member type
  - value_type begin member
  - value_type end member
- Added CLink.h include to Platform.Interfaces.h
- Added CLinkAddress.h include to Platform.Interfaces.h (was missing)
- Added comprehensive test in examples/test_clink.cpp
- All tests pass successfully

Fixes #102

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
@konard konard changed the title [WIP] Create concept Create CLink concept Sep 10, 2025
@konard konard marked this pull request as ready for review September 10, 2025 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@konard konard

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Create CLink concept

2 participants

@konard