Use TObject& instead of TObject in CProperties concept #127
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding CLAUDE.md with task information for AI processing. This file will be removed when the task is complete. Issue: #88
Changed the concept definition to use TObject& instead of TObject in the requires expression to better handle reference types in template parameters. This allows the concept to work correctly when TObject is already a reference type (int&, const int&). Fixes #88 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
konard
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
TObject&instead ofTObjectin the requires expressionint&,const int&)Changes Made
cpp/Platform.Interfaces/CProperties.hline 7 to useTObject& objectinstead ofTObject objectin the concept requirementsTest Plan
int)int&)const int&)Background
The issue was reported as needing to use
TObject&instead ofTObjectin concepts. The problem was that when testing concepts with reference types likeCProperties<EmptyProperties, int&, int, int>, the original definition usingTObject objectdidn't handle reference type parameters optimally. By changing toTObject& object, the concept now works correctly with both value types and reference types.Fixes #88
🤖 Generated with Claude Code