Rename ICriterionMatcher to IMatcher for improved simplicity and clarity #138
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding CLAUDE.md with task information for AI processing. This file will be removed when the task is complete. Issue: #9
- Renamed ICriterionMatcher<TArgument> to IMatcher<TArgument> in both C# and C++ implementations - Updated CCriterionMatcher concept to CMatcher in C++ - Updated all references in test files and header includes - Simplified documentation comments to reflect the more generic naming - Maintains the same interface contract with IsMatched(TArgument) method This change improves API clarity by using a simpler, more intuitive name while preserving all existing functionality. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
konard
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR resolves issue #9 by renaming
ICriterionMatcher<TArgument>toIMatcher<TArgument>across both C# and C++ implementations.Changes Made
ICriterionMatcher<TArgument>interface toIMatcher<TArgument>ICriterionMatcher<TArgument>struct toIMatcher<TArgument>CCriterionMatcherconcept toCMatcherRationale
The new name
IMatcheris:IsMatched()clearly conveys the behaviorTest Results
Fixes #9
🤖 Generated with Claude Code