Fix all warnings in C# workflow #144
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes all the warnings identified in issue #143 that were appearing in the C# workflow:
InterfacesTests.csby making interface variables nullable (10 warnings eliminated)set-outputcommand warning by updating to useGITHUB_OUTPUTenvironment file insteadPackageIconapproach with local icon fileactions/checkoutversions from v1/v3 to v4 for consistency and to eliminate deprecation warningsTest Plan
dotnet testpasses cleanly)Changes Made
1. Fixed Nullable Reference Type Warnings
File:
csharp/Platform.Interfaces.Tests/InterfacesTests.cs?operator2. Updated GitHub Actions Workflow
File:
.github/workflows/csharp.ymlset-outputcommand to useGITHUB_OUTPUTenvironment fileactions/checkout@v1andactions/checkout@v3toactions/checkout@v43. Modernized NuGet Package Configuration
File:
csharp/Platform.Interfaces/Platform.Interfaces.csprojPackageIconUrlwith modernPackageIconapproachicon.pngfile to project with proper pack configuration🤖 Generated with Claude Code
Resolves #143