Migrate Rust code to latest stable toolchain #126
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding CLAUDE.md with task information for AI processing. This file will be removed when the task is complete. Issue: #125
- Remove unstable feature flags (#![feature(step_trait)] and #![feature(trait_alias)]) - Remove Step trait bound from LinkType (required for stable Rust - Step is still unstable) - Update Rust edition from 2018 to 2021 - Update rust-toolchain.toml from nightly-2022-08-22 to stable - Update num-traits dependency from 0.2.14 to 0.2.19 - Set minimum Rust version (MSRV) to 1.70 - Update CI workflow to use dtolnay/rust-toolchain@stable BREAKING CHANGE: LinkType trait no longer requires Step bound. This is necessary because std::iter::Step remains unstable (rust-lang/rust#42168). Fixes #125 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
konard
changed the title
This reverts commit e4c3df5.
Member
Author
🤖 Solution Draft LogThis log file contains the complete execution trace of the AI solution draft process. 💰 Cost estimation:
Now working session is ended, feel free to review and add any feedback on the solution draft. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR migrates the Rust codebase from nightly-2022-08-22 to the latest stable Rust toolchain.
Changes
#![feature(step_trait)]and#![feature(trait_alias)])Steptrait bound fromLinkTypetrait (required for stable Rust)rust-toolchain.tomlfromnightly-2022-08-22tostablenum-traitsdependency from 0.2.14 to 0.2.19dtolnay/rust-toolchain@stableBreaking Change
The
LinkTypetrait no longer requires theStepbound. This is necessary becausestd::iter::Stepremains unstable in Rust (tracked in rust-lang/rust#42168).If any downstream code relies on iterating over ranges of
LinkTypevalues directly, it will need to be updated.Testing
Test plan
cargo buildwith stable toolchaincargo test- all 67 tests passcargo fmt --check- formatting is correctFixes #125
🤖 Generated with Claude Code