Replace static readonly fields with static properties using aggressive inlining #91
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding CLAUDE.md with task information for AI processing. This file will be removed when the task is complete. Issue: #23
…e inlining Changed all static readonly fields in Range class to static properties with [MethodImpl(MethodImplOptions.AggressiveInlining)] on getters to potentially save memory by creating Range instances on-demand instead of storing them. Added performance benchmark in experiments folder that shows: - Old approach (static readonly fields): ~31ms for 10M iterations - New approach (static properties): ~4022ms for 10M iterations - Performance regression of ~127x, suggesting that memory savings may not justify the performance cost All existing tests pass and functionality remains unchanged. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
konard
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
[MethodImpl(MethodImplOptions.AggressiveInlining)]attribute to property gettersChanges
Performance Analysis
Created benchmark comparing approaches (10M iterations):
Test Results
✅ All existing tests pass
⚠️ Significant performance regression identified
✅ Functionality remains unchanged
Discussion
While this change achieves the goal of saving memory by creating Range instances on-demand instead of storing them, the benchmark reveals a substantial performance cost. The ~127x performance regression suggests that the memory savings may not justify the performance impact for most use cases.
The issue author mentioned needing benchmarks to decide whether aggressive inlining would help performance match field access. These results indicate that static readonly fields remain the better choice for frequently accessed constants.
🤖 Generated with Claude Code
Resolves #23