feat: Add support for postgresql 18 #160

fila43 · 2026-01-26T09:03:37Z

Enhancement: Add support for postgresql 18

Issue Tracker Tickets (Jira or BZ if any): RHEL-136892

Summary by Sourcery

Add PostgreSQL 18 as a supported version in the role and related messaging.

Enhancements:

Extend supported PostgreSQL versions for RHEL 9 and RHEL 10 variables to include version 18.
Update validation error messaging to mention PostgreSQL 18 as supported on RHEL 9.

Documentation:

Document PostgreSQL 18 as a supported server version and valid value for postgresql_version.

sourcery-ai · 2026-01-26T09:03:50Z

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Adds PostgreSQL 18 support to the Ansible role by updating supported version lists, OS-specific version matrices, and user-facing documentation/messages for RHEL 9 and 10.

Flow diagram for PostgreSQL version validation with added 18 support

flowchart TD
  A[User sets variable postgresql_version] --> B[Gather ansible_facts]
  B --> C{distribution_major_version}

  C --> D[RHEL8]
  C --> E[RHEL9]
  C --> F[RHEL10]

  D --> G{postgresql_version in __postgresql_versions_el8 10,12,13,15,16}
  G -->|yes| H[Proceed with role execution]
  G -->|no| I[Fail: unsupported PostgreSQL version for RHEL8]

  E --> J{postgresql_version in __postgresql_versions_el9 13,15,16,18}
  J -->|yes| H
  J -->|no| K[Fail: RHEL 9 supports only Postgresql 13,15,16,18]

  F --> L{postgresql_version in __postgresql_versions_el10 16,18}
  L -->|yes| H
  L -->|no| M[Fail: unsupported PostgreSQL version for RHEL10]

File-Level Changes

Change	Details	Files
Extend documented and configurable PostgreSQL versions to include 18.	Update README support statement to list PostgreSQL 18 among supported versions. Update README description of the postgresql_version variable to allow 18 as a valid value.	`README.md`
Update internal version matrices to support PostgreSQL 18 on RHEL 9 and RHEL 10.	Extend __postgresql_versions_el9 to include version 18. Extend __postgresql_versions_el10 to include version 18.	`vars/main.yml`
Align runtime validation error message with new PostgreSQL 18 support on RHEL 9.	Change RHEL 9 validation failure message to mention PostgreSQL 18 as supported.	`tasks/main.yml`

Tips and commands

Interacting with Sourcery

Trigger a new review: Comment @sourcery-ai review on the pull request.
Continue discussions: Reply directly to Sourcery's review comments.
Generate a GitHub issue from a review comment: Ask Sourcery to create an
issue from a review comment by replying to it. You can also reply to a
review comment with @sourcery-ai issue to create an issue from it.
Generate a pull request title: Write @sourcery-ai anywhere in the pull
request title to generate a title at any time. You can also comment
@sourcery-ai title on the pull request to (re-)generate the title at any time.
Generate a pull request summary: Write @sourcery-ai summary anywhere in
the pull request body to generate a PR summary at any time exactly where you
want it. You can also comment @sourcery-ai summary on the pull request to
(re-)generate the summary at any time.
Generate reviewer's guide: Comment @sourcery-ai guide on the pull
request to (re-)generate the reviewer's guide at any time.
Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
pull request to resolve all Sourcery comments. Useful if you've already
addressed all the comments and don't want to see them anymore.
Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
request to dismiss all existing Sourcery reviews. Especially useful if you
want to start fresh with a new review - don't forget to comment
@sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

Enable or disable review features such as the Sourcery-generated pull request
summary, the reviewer's guide, and others.
Change the review language.
Add, remove or edit custom review instructions.
Adjust other review settings.

Getting Help

Contact our support team for questions or feedback.
Visit our documentation for detailed guides and information.
Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

sourcery-ai

Hey - I've found 1 issue, and left some high level feedback:

The README now claims the role supports PostgreSQL 18 generally, but __postgresql_versions_el8 does not include "18", so either add 18 to the EL8 versions or clarify in the README that 18 support is limited to specific RHEL versions.
The hard-coded error message for RHEL 9 supported versions in tasks/main.yml should ideally be derived from the __postgresql_versions_el9 variable or otherwise kept in one place to avoid future drift when supported versions change.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- The README now claims the role supports PostgreSQL 18 generally, but `__postgresql_versions_el8` does not include "18", so either add 18 to the EL8 versions or clarify in the README that 18 support is limited to specific RHEL versions.
- The hard-coded error message for RHEL 9 supported versions in `tasks/main.yml` should ideally be derived from the `__postgresql_versions_el9` variable or otherwise kept in one place to avoid future drift when supported versions change.

## Individual Comments

### Comment 1
<location> `tasks/main.yml:21` </location>
<code_context>
 - name: Check if requested version is supported in system (RHEL9)
   fail:
-    msg: RHEL 9 supports only Postgresql 13, 15 and 16
+    msg: RHEL 9 supports only Postgresql 13, 15, 16 and 18
   when:
     - ansible_facts["os_family"] == "RedHat"
</code_context>

<issue_to_address>
**suggestion:** Avoid hardcoding version list in the error message; derive it from the RHEL9 versions variable to keep them in sync.

Because `__postgresql_versions_el9` already defines the supported versions (13, 15, 16, 18), this message now duplicates that list. To avoid future drift, generate the message dynamically from `__postgresql_versions_el9` (e.g., via `join`/`map`) so it always reflects the configured supported versions.
</issue_to_address>

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

sourcery-ai · 2026-01-26T09:04:43Z

tasks/main.yml

 - name: Check if requested version is supported in system (RHEL9)
  fail:
-    msg: RHEL 9 supports only Postgresql 13, 15 and 16
+    msg: RHEL 9 supports only Postgresql 13, 15, 16 and 18


suggestion: Avoid hardcoding version list in the error message; derive it from the RHEL9 versions variable to keep them in sync.

Because __postgresql_versions_el9 already defines the supported versions (13, 15, 16, 18), this message now duplicates that list. To avoid future drift, generate the message dynamically from __postgresql_versions_el9 (e.g., via join/map) so it always reflects the configured supported versions.

richm · 2026-01-26T15:37:21Z

@fila43 package or module name changed?

TASK [linux-system-roles.postgresql : Ensure required packages are installed] ***
task path: /home/rmeggins/linux-system-roles/postgresql/tests/roles/linux-system-roles.postgresql/tasks/main.yml:49
Monday 26 January 2026  08:33:50 -0700 (0:00:00.012)       0:00:42.456 ******** 
[ERROR]: Task failed: Module failed: No group postgresql:18/server available.

fila43 · 2026-01-27T07:08:51Z

@fila43 package or module name changed?

TASK [linux-system-roles.postgresql : Ensure required packages are installed] ***
task path: /home/rmeggins/linux-system-roles/postgresql/tests/roles/linux-system-roles.postgresql/tasks/main.yml:49
Monday 26 January 2026  08:33:50 -0700 (0:00:00.012)       0:00:42.456 ******** 
[ERROR]: Task failed: Module failed: No group postgresql:18/server available.

We realized there was an issue, and the component is missing from the c9s compose. We are working on it

fila43 · 2026-01-28T12:49:45Z

@richm now it should be fixed

richm · 2026-01-28T14:19:00Z

[citest]

richm · 2026-01-28T14:38:34Z

@richm now it should be fixed

Are we still waiting for a fix for CentOS 10?

richm · 2026-01-28T15:11:35Z

vars/RedHat_10.yml

-  {{ ['@postgresql:' + postgresql_version +
-       '/server'] if postgresql_version != '16' else
-       ['postgresql-server'] }}
+  {{ ['@postgresql' + postgresql_version +


@fila43
Now failing because @postgresql16-server is not found - do we need to have logic that uses @postgresql:N/server for N < 18, and @postgresqlN-server for N >= 18?

richm · 2026-01-28T17:02:46Z

vars/RedHat_10.yml

-  {{ ['@postgresql:' + postgresql_version +
-       '/server'] if postgresql_version != '16' else
-       ['postgresql-server'] }}
+  {{ ['@postgresql' + postgresql_version +


Suggested change

{{ ['@postgresql' + postgresql_version +

{{ ['postgresql' + postgresql_version +

looks like it isn't a group/module anymore, it's just a regular package?

fila43 requested review from richm and spetrosi as code owners January 26, 2026 09:03

sourcery-ai bot reviewed Jan 26, 2026

View reviewed changes

richm changed the title ~~fix: Add support for postgresql 18~~ feat: Add support for postgresql 18 Jan 26, 2026

Add support for postgresql 18

ee7d071

fila43 force-pushed the main branch from 22cb836 to ee7d071 Compare January 28, 2026 15:00

richm reviewed Jan 28, 2026

View reviewed changes

	{{ ['@postgresql' + postgresql_version +
	{{ ['postgresql' + postgresql_version +

feat: Add support for postgresql 18 #160

Are you sure you want to change the base?

feat: Add support for postgresql 18 #160

Conversation

fila43 commented Jan 26, 2026 • edited by sourcery-ai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by Sourcery

Uh oh!

sourcery-ai bot commented Jan 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer's Guide

Flow diagram for PostgreSQL version validation with added 18 support

File-Level Changes

Interacting with Sourcery

Customizing Your Experience

Getting Help

Uh oh!

sourcery-ai bot left a comment

Choose a reason for hiding this comment

Uh oh!

sourcery-ai bot Jan 26, 2026

Choose a reason for hiding this comment

Uh oh!

richm commented Jan 26, 2026

Uh oh!

fila43 commented Jan 27, 2026

Uh oh!

fila43 commented Jan 28, 2026

Uh oh!

richm commented Jan 28, 2026

Uh oh!

richm commented Jan 28, 2026

Uh oh!

richm Jan 28, 2026

Choose a reason for hiding this comment

Uh oh!

richm Jan 28, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

fila43 commented Jan 26, 2026 •

edited by sourcery-ai bot

Loading

sourcery-ai bot commented Jan 26, 2026 •

edited

Loading