Skip to content

Check if qgroup exists before attempting to destroy it #484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mtwebster merged 1 commit into from
Dec 4, 2025
Merged

Check if qgroup exists before attempting to destroy it #484

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 20 additions & 9 deletions src/Core/Subvolume.vala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,20 +193,31 @@ public class Subvolume : GLib.Object{
sleep(1000);
}

log_msg("%s: 0/%ld".printf(_("Destroying qgroup"), id));

cmd = "btrfs qgroup destroy 0/%ld '%s'".printf(id, repo.mount_paths[name]);
// Check if qgroup still exists before trying to destroy it.
// The qgroup may have been auto-destroyed when the subvolume was deleted.
string qgroup_id = "0/%ld".printf(id);
cmd = "btrfs qgroup show -f '%s'".printf(repo.mount_paths[name]);
log_debug(cmd);
ret_val = exec_sync(cmd, out std_out, out std_err);
if (ret_val != 0){
log_error(_("Failed to destroy qgroup") + ": '0/%ld'".printf(id));

// the subvolume is gone now. So this can be called a success.
return true;
bool qgroup_exists = (ret_val == 0) && (std_out.contains(qgroup_id));

if (!qgroup_exists) {
log_debug("Qgroup %s already removed (auto-destroyed with subvolume)".printf(qgroup_id));
} else {
log_msg("%s: %s".printf(_("Destroying qgroup"), qgroup_id));

cmd = "btrfs qgroup destroy %s '%s'".printf(qgroup_id, repo.mount_paths[name]);
log_debug(cmd);
ret_val = exec_sync(cmd, out std_out, out std_err);
if (ret_val != 0){
// Qgroup may have been destroyed between our check and destroy attempt
log_debug("Qgroup %s could not be destroyed (likely already removed): %s".printf(qgroup_id, std_err));
} else {
log_msg("%s: %s\n".printf(_("Destroyed qgroup"), qgroup_id));
}
}

log_msg("%s: 0/%ld\n".printf(_("Destroyed qgroup"), id));

log_debug("Rescanning quotas (post)...");
while (exec_sync("btrfs quota rescan %s".printf(mount_path), out std_out, out std_err) != 0) {
log_debug("Still rescanning quotas (post)... %s".printf(std_err));
Expand Down
Loading