CARE no cglib #111
CARE no cglib #111
Conversation
…out rebuilding the class
… and temporarly run this test many times
| public class RDBITest { | ||
|
|
||
| interface TestDAO { | ||
| public interface TestDAO { |
There was a problem hiding this comment.
this type of change will probably cause some problems for updating users. if the interface isn't in the com.lithium.dbi.rdbi package, we are unable to create a proxy for it unless it is public (previously we could).
rdbi-parent/pom.xml
Outdated
| <source>1.8</source> | ||
| <target>1.8</target> | ||
| <source>11</source> | ||
| <target>11</target> |
There was a problem hiding this comment.
could probably still build this for 1.8, otherwise we'll need to maintain a separate java11+ release branch
| <dependency> | ||
| <groupId>cglib</groupId> | ||
| <artifactId>cglib-nodep</artifactId> | ||
| <groupId>net.bytebuddy</groupId> |
There was a problem hiding this comment.
neat, where did you find this library?
it's like a mostly drop in replacement of cglib.
There was a problem hiding this comment.
from the cglib homepage - https://github.com/cglib/cglib
IMPORTANT NOTE: cglib is unmaintained and does not work well (or possibly at all?) in newer JDKs, particularly JDK17+. If you need to support newer JDKs, we will accept well-tested well-thought-out patches... but you'll probably have better luck migrating to something like ByteBuddy.
no cg lib
why?
trying to go to java 17
cglib relies on internal apis that are no longer available
They recommend you use byte buddy or something like it