Skip to content

feat: support functions for connection #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
NormalDuck wants to merge 2 commits into
base: master
Choose a base branch
from
+4 −1
Open

feat: support functions for connection #23

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5c1975e
feat: support functions for connection
NormalDuck May 18, 2025
ef2a6a7
fix: run function check before prop checks
NormalDuck May 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/use-event-listener/use-event-listener.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,8 @@ interface EventListenerOptions {
type EventLike<T extends Callback = Callback> =
| { Connect(callback: T): ConnectionLike }
| { connect(callback: T): ConnectionLike }
| { subscribe(callback: T): ConnectionLike };
| { subscribe(callback: T): ConnectionLike }
| ((callback: T) => ConnectionLike);

type ConnectionLike = { Disconnect(): void } | { disconnect(): void } | (() => void);

Expand All @@ -32,6 +33,8 @@ const connect = (event: EventLike, callback: Callback): ConnectionLike => {
}
});
return connection;
} else if (typeIs(event, "function")) {
return event(callback);
} else if ("Connect" in event) {
return event.Connect(callback);
} else if ("connect" in event) {
Expand Down