Skip to content

runner: add data_url to route/pipeline and codegen #710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ad-astra-video wants to merge 3 commits into
base: main
Choose a base branch
from
Open

runner: add data_url to route/pipeline and codegen #710

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e0cb052
add data_url to routes and openapi gen
ad-astra-video Jul 22, 2025
33de59f
update openapi for live-video-to-video data_url
ad-astra-video Jul 22, 2025
c37be69
add data_url field to LiveVideoToVideoResponse
ad-astra-video Aug 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion runner/app/pipelines/live_video_to_video.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ def __init__(self, model_id: str):
self.start_process()

def __call__( # type: ignore
self, *, subscribe_url: str, publish_url: str, control_url: str, events_url: str, params: dict, request_id: str, manifest_id: str, stream_id: str, **kwargs
self, *, subscribe_url: str, publish_url: str, control_url: str, events_url: str, data_url: str, params: dict, request_id: str, manifest_id: str, stream_id: str, **kwargs
):
if not self.process:
raise RuntimeError("Pipeline process not running")
Expand All @@ -51,6 +51,7 @@ def __call__( # type: ignore
"publish_url": publish_url,
"control_url": control_url,
"events_url": events_url,
"data_url": data_url,
"params": params,
"request_id": request_id or "",
"manifest_id": manifest_id or "",
Expand Down
7 changes: 7 additions & 0 deletions runner/app/routes/live_video_to_video.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,13 @@ class LiveVideoToVideoParams(BaseModel):
description="URL for publishing events via Trickle protocol for pipeline status and logs.",
),
]
data_url: Annotated[
str,
Field(
default="",
description="URL for publishing data via Trickle protocol for pipeline status and logs.",
Comment on lines 58 to +65
Copy link

Copilot AI Jul 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The description for data_url is identical to events_url except for the word 'data' vs 'events'. This doesn't clearly explain what distinguishes data_url from events_url or what type of data will be published through this URL.

Suggested change
description="URL for publishing events via Trickle protocol for pipeline status and logs.",
),
]
data_url: Annotated[
str,
Field(
default="",
description="URL for publishing data via Trickle protocol for pipeline status and logs.",
description="URL for publishing pipeline status updates and logs via the Trickle protocol.",
),
]
data_url: Annotated[
str,
Field(
default="",
description="URL for publishing processed data or results generated by the pipeline via the Trickle protocol.",

Copilot uses AI. Check for mistakes.
),
]
model_id: Annotated[
str,
Field(
Expand Down
4 changes: 4 additions & 0 deletions runner/app/routes/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,6 +131,10 @@ class LiveVideoToVideoResponse(BaseModel):
default='',
description="URL for subscribing to events for pipeline status and logs",
)
data_url: str = Field(
default='',
description="URL for publishing data for pipeline",
)
request_id: str = Field(
default='',
description="The ID generated for this request",
Expand Down
11 changes: 11 additions & 0 deletions runner/gateway.openapi.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1000,6 +1000,12 @@ components:
description: URL for publishing events via Trickle protocol for pipeline
status and logs.
default: ''
data_url:
type: string
title: Data Url
description: URL for publishing data via Trickle protocol for pipeline status
and logs.
Comment on lines 996 to +1007
Copy link

Copilot AI Jul 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The description for data_url is identical to events_url except for the word 'data' vs 'events'. This doesn't clearly explain what distinguishes data_url from events_url or what type of data will be published through this URL.

Suggested change
description: URL for publishing events via Trickle protocol for pipeline
status and logs.
default: ''
data_url:
type: string
title: Data Url
description: URL for publishing data via Trickle protocol for pipeline status
and logs.
description: URL for publishing events, such as pipeline status updates and
logs, via the Trickle protocol.
default: ''
data_url:
type: string
title: Data Url
description: URL for publishing processed data or intermediate results via
the Trickle protocol.

Copilot uses AI. Check for mistakes.
default: ''
model_id:
type: string
title: Model Id
Expand Down Expand Up @@ -1055,6 +1061,11 @@ components:
title: Events Url
description: URL for subscribing to events for pipeline status and logs
default: ''
data_url:
type: string
title: Data Url
description: URL for publishing data for pipeline
default: ''
request_id:
type: string
title: Request Id
Expand Down
11 changes: 11 additions & 0 deletions runner/openapi.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1158,6 +1158,12 @@ components:
description: URL for publishing events via Trickle protocol for pipeline
status and logs.
default: ''
data_url:
type: string
title: Data Url
description: URL for publishing data via Trickle protocol for pipeline status
and logs.
Comment on lines 1154 to +1165
Copy link

Copilot AI Jul 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The description for data_url is identical to events_url except for the word 'data' vs 'events'. This doesn't clearly explain what distinguishes data_url from events_url or what type of data will be published through this URL.

Suggested change
description: URL for publishing events via Trickle protocol for pipeline
status and logs.
default: ''
data_url:
type: string
title: Data Url
description: URL for publishing data via Trickle protocol for pipeline status
and logs.
description: URL for publishing event-related information, such as pipeline
status updates and logs, via the Trickle protocol.
default: ''
data_url:
type: string
title: Data Url
description: URL for publishing data outputs generated by the pipeline, such as
processed video frames or analysis results, via the Trickle protocol.

Copilot uses AI. Check for mistakes.
default: ''
model_id:
type: string
title: Model Id
Expand Down Expand Up @@ -1212,6 +1218,11 @@ components:
title: Events Url
description: URL for subscribing to events for pipeline status and logs
default: ''
data_url:
type: string
title: Data Url
description: URL for publishing data for pipeline
default: ''
request_id:
type: string
title: Request Id
Expand Down