Skip to content

Spack 1.1 & TPL v2025.12.0 updates #1769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
bmhan12 wants to merge 20 commits into
base: develop
Choose a base branch
from
Draft

Spack 1.1 & TPL v2025.12.0 updates #1769

bmhan12 wants to merge 20 commits into from

Conversation

@bmhan12
Copy link
Contributor

@bmhan12 bmhan12 commented Jan 12, 2026 •
edited by rhornung67
Loading

This PR:

  • Updates Spack to 1.1
  • Updates the RAJA suite of packages to v2025.12.x
    • Updates Docker images

TODO:

@bmhan12 bmhan12 added TPL Issues related to Axom's third party libraries Testing Issues related to testing Axom Build system Issues related to Axom's build system labels Jan 12, 2026
bmhan12
bmhan12 commented Jan 12, 2026
View reviewed changes
scripts/spack/packages/axom/package.py
hip_link_flags = ""

rocm_root = os.path.dirname(spec["llvm-amdgpu"].prefix)
rocm_root = spec["llvm-amdgpu"].prefix
Copy link
Contributor Author

@bmhan12 bmhan12 Jan 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here and in toss_4_x86_64_ib_cray/spack.yaml, I incorporated changes from @adrienbernede 's PR #1739 to get things working with Spack 1.1 .

bmhan12
bmhan12 commented Jan 12, 2026
View reviewed changes
scripts/vcpkg_ports/raja/vcpkg_raja_openmp.patch Outdated
Comment on lines 9 to 12
+// Include OpenMP header for Windows
+#if defined(_OPENMP)
+#include <omp.h>
+#endif
Copy link
Contributor Author

@bmhan12 bmhan12 Jan 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This patch file is part of my attempt to get raja v25.12.0 working with Windows.

Following error without this patch:

D:\a\axom\axom\uberenv_libs\vcpkg\buildtrees\raja\src\v2025.12.0-beae201c76.clean\include\RAJA/policy/openmp/thread.hpp(35): error C3861: 'omp_get_max_threads': identifier not found
D:\a\axom\axom\uberenv_libs\vcpkg\buildtrees\raja\src\v2025.12.0-beae201c76.clean\include\RAJA/policy/openmp/thread.hpp(41): error C3861: 'omp_get_thread_num': identifier not found

@bmhan12 bmhan12 force-pushed the feature/han12/spack_12_25 branch 2 times, most recently from b1ced68 to 2b540e7 Compare January 12, 2026 23:08
@bmhan12
Copy link
Contributor Author

bmhan12 commented Jan 13, 2026 •
edited
Loading

Additional context from testing:

On Windows, I've tried building RAJA v2025.12.0 and v2025.09.1 (current version is v2025.09.0), both fail during compilation of Axom with the errors:

D:\a\axom\axom\uberenv_libs\vcpkg\installed\x64-windows\include\RAJA\policy\openmp\forall.hpp(93,5): error C3001: 'declare': expected an OpenMP directive name...
D:\a\axom\axom\uberenv_libs\vcpkg\installed\x64-windows\include\RAJA\policy\openmp\forall.hpp(98,27): error C3036: 'combine': invalid operator token in OpenMP 'reduction' clause...

EDIT: Between v2025.09.0 and v2025.09.1, this seems to be the most relevant PR to openmp changes? llnl/RAJA#1884

@bmhan12 bmhan12 force-pushed the feature/han12/spack_12_25 branch 2 times, most recently from 2e8ff18 to 6c57b7f Compare January 13, 2026 16:50
@rhornung67
Copy link
Member

rhornung67 commented Jan 13, 2026

@bmhan12 to be clear: it works with RAJA 2025.09.0 and breaks with RAJA 2025.09.1 and newer?

@bmhan12
Copy link
Contributor Author

bmhan12 commented Jan 13, 2026

@bmhan12 to be clear: it works with RAJA 2025.09.0 and breaks with RAJA 2025.09.1 and newer?

Yes.

@rhornung67
Copy link
Member

rhornung67 commented Jan 13, 2026

@bmhan12 to be clear: it works with RAJA 2025.09.0 and breaks with RAJA 2025.09.1 and newer?

Yes.

Thank you. I've got John looking into it. His RAJA PR seems to be the cause of the breakage.

@bmhan12 bmhan12 force-pushed the feature/han12/spack_12_25 branch from 6c57b7f to f871cec Compare January 13, 2026 21:14
bmhan12 and others added 16 commits January 15, 2026 10:50
@bmhan12 bmhan12 force-pushed the feature/han12/spack_12_25 branch from f871cec to 196daf5 Compare January 15, 2026 18:58
@bmhan12 bmhan12 force-pushed the feature/han12/spack_12_25 branch from 25601d9 to 9f2f2dc Compare January 16, 2026 15:47
@bmhan12 bmhan12 force-pushed the feature/han12/spack_12_25 branch from 9f2f2dc to ea0f6f7 Compare January 16, 2026 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Build system Issues related to Axom's build system Testing Issues related to testing Axom TPL Issues related to Axom's third party libraries

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bmhan12 @rhornung67