[libc++] Remove unused __parent_pointer alias from __tree and map

[Krechals]

The __parent_pointer type alias was marked to be removed in d163ab3.
At that time, still had uses of __parent_pointer as a local variable type in operator[] and at()

Those uses were removed in 4a2dd31, which refactored __find_equal to return a pair instead of using an out parameter

However, the typedef in and the alias in __tree were left behind

This patch removes the unused typedef from and the __parent_pointer alias from __tree

[github-actions]

Thank you for submitting a Pull Request (PR) to the LLVM Project!

This PR will be automatically labeled and the relevant teams will be notified.

If you wish to, you can add reviewers by using the "Reviewers" section on this page.

If this is not working for you, it is probably because you do not have write permissions for the repository. In which case you can instead tag reviewers by name in a comment by using @ followed by their GitHub username.

If you have received no comments on your PR for a week, you can request a review by "ping"ing the PR by adding a comment “Ping”. The common courtesy "ping" rate is once a week. Please remember that you are asking for valuable time from other developers.

If you have further questions, they may be answered by the LLVM GitHub User Guide.

You can also ask questions in a comment on this PR, on the LLVM Discord or on the forums.

[llvmbot]

@llvm/pr-subscribers-libcxx

Author: Andrei Topala (Krechals)

Changes

The __parent_pointer type alias was marked to be removed in d163ab3.
At that time, <map> still had uses of __parent_pointer as a local variable type in operator[] and at()

Those uses were removed in 4a2dd31, which refactored __find_equal to return a pair instead of using an out parameter

However, the typedef in <map> and the alias in __tree were left behind

This patch removes the unused typedef from <map> and the __parent_pointer alias from __tree

---

Full diff: https://github.com/llvm/llvm-project/pull/172185.diff

2 Files Affected:

• (modified) libcxx/include/__tree (-2)
• (modified) libcxx/include/map (-1)

diff --git a/libcxx/include/__tree b/libcxx/include/__tree
index 22aa186470bda..6f81c6d2bf9fd 100644
--- a/libcxx/include/__tree
+++ b/libcxx/include/__tree
@@ -907,8 +907,6 @@ public:
   using __end_node_t _LIBCPP_NODEBUG       = __tree_end_node<__node_base_pointer>;
   using __end_node_pointer _LIBCPP_NODEBUG = __rebind_pointer_t<__void_pointer, __end_node_t>;
 
-  using __parent_pointer _LIBCPP_NODEBUG = __end_node_pointer; // TODO: Remove this once the uses in <map> are removed
-
   using __node_allocator _LIBCPP_NODEBUG = __rebind_alloc<__alloc_traits, __node>;
   using __node_traits _LIBCPP_NODEBUG    = allocator_traits<__node_allocator>;
 
diff --git a/libcxx/include/map b/libcxx/include/map
index 2f5bcba6835c9..324c8d69be735 100644
--- a/libcxx/include/map
+++ b/libcxx/include/map
@@ -1418,7 +1418,6 @@ private:
   typedef typename __base::__node_allocator __node_allocator;
   typedef typename __base::__node_pointer __node_pointer;
   typedef typename __base::__node_base_pointer __node_base_pointer;
-  typedef typename __base::__parent_pointer __parent_pointer;
 
   typedef __map_node_destructor<__node_allocator> _Dp;
   typedef unique_ptr<__node, _Dp> __node_holder;

[Krechals]

I don’t have access to the Reviewers section, so I’m tagging @ldionne for review

[philnik777]

I don’t have access to the Reviewers section, so I’m tagging @ldionne for review

People get messaged automatically. No need to ping them.

[github-actions]

@Krechals Congratulations on having your first Pull Request (PR) merged into the LLVM Project!

Your changes will be combined with recent changes from other authors, then tested by our build bots. If there is a problem with a build, you may receive a report in an email or a comment on this PR.

Please check whether problems have been caused by your change specifically, as the builds can include changes from many authors. It is not uncommon for your change to be included in a build that fails due to someone else's changes, or infrastructure issues.

How to do this, and the rest of the post-merge process, is covered in detail here.

If your change does cause a problem, it may be reverted, or you can revert it yourself. This is a normal part of LLVM development. You can fix your changes and open a new PR to merge them again.

If you don't get any reports, no action is required from you. Your changes are working as expected, well done!