Skip to content

[clang-tidy] Suggest std::views::reverse instead of std::ranges::reverse_view in modernize-use-ranges #172199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
localspook merged 2 commits into from
Dec 15, 2025
Merged

[clang-tidy] Suggest std::views::reverse instead of std::ranges::reverse_view in modernize-use-ranges #172199

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9ff62d7
[clang-tidy] Suggest `std::views::reverse` instead of `std::ranges::r…
localspook Dec 14, 2025
1882c0b
Update docs
localspook Dec 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion clang-tools-extra/clang-tidy/modernize/LoopConvertCheck.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1079,7 +1079,7 @@ llvm::StringRef LoopConvertCheck::getReverseFunction() const {
if (!ReverseFunction.empty())
return ReverseFunction;
if (UseReverseRanges)
return "std::ranges::reverse_view";
return "std::views::reverse";
return "";
}

Expand Down
5 changes: 2 additions & 3 deletions clang-tools-extra/clang-tidy/modernize/UseRangesCheck.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,8 +197,7 @@ std::optional<UseRangesCheck::ReverseIteratorDescriptor>
UseRangesCheck::getReverseDescriptor() const {
static const std::pair<StringRef, StringRef> Refs[] = {
{"::std::rbegin", "::std::rend"}, {"::std::crbegin", "::std::crend"}};
return ReverseIteratorDescriptor{UseReversePipe ? "std::views::reverse"
: "std::ranges::reverse_view",
"<ranges>", Refs, UseReversePipe};
return ReverseIteratorDescriptor{"std::views::reverse", "<ranges>", Refs,
UseReversePipe};
}
} // namespace clang::tidy::modernize
5 changes: 5 additions & 0 deletions clang-tools-extra/docs/ReleaseNotes.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -508,6 +508,11 @@ Changes in existing checks
on Windows when the check was enabled with a 32-bit :program:`clang-tidy`
binary.

- Improved :doc:`modernize-use-ranges
<clang-tidy/checks/modernize/use-ranges>` check to suggest using
the more idiomatic ``std::views::reverse`` where it used to suggest
``std::ranges::reverse_view``.

- Improved :doc:`modernize-use-scoped-lock
<clang-tidy/checks/modernize/use-scoped-lock>` check by fixing a crash
on malformed code (common when using :program:`clang-tidy` through
Expand Down
4 changes: 2 additions & 2 deletions clang-tools-extra/docs/clang-tidy/checks/modernize/loop-convert.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,15 +147,15 @@ Options
.. option:: UseCxx20ReverseRanges

When set to true convert loops when in C++20 or later mode using
``std::ranges::reverse_view``.
``std::views::reverse``.
Default value is `true`.

.. option:: MakeReverseRangeFunction

Specify the function used to reverse an iterator pair, the function should
accept a class with ``rbegin`` and ``rend`` methods and return a
class with ``begin`` and ``end`` methods that call the ``rbegin`` and
``rend`` methods respectively. Common examples are ``ranges::reverse_view``
``rend`` methods respectively. Common examples are ``std::views::reverse``
and ``llvm::reverse``.
Default value is an empty string.

Expand Down
4 changes: 2 additions & 2 deletions clang-tools-extra/docs/clang-tidy/checks/modernize/use-ranges.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,8 +122,8 @@ Transforms to:

.. code-block:: c++

auto AreSame = std::ranges::equal(std::ranges::reverse_view(Items1),
std::ranges::reverse_view(Items2));
auto AreSame = std::ranges::equal(std::views::reverse(Items1),
std::views::reverse(Items2));

Options
-------
Expand Down
14 changes: 7 additions & 7 deletions clang-tools-extra/test/clang-tidy/checkers/modernize/loop-convert-reverse.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ void constContainer(const Reversable<int> &Numbers) {
observe(*I);
}
// CHECK-MESSAGES: :[[@LINE-3]]:3: warning: use range-based for loop instead
// CHECK-FIXES-RANGES: for (int Number : std::ranges::reverse_view(Numbers)) {
// CHECK-FIXES-RANGES: for (int Number : std::views::reverse(Numbers)) {
// CHECK-FIXES-CUSTOM: for (int Number : llvm::reverse(Numbers)) {
// CHECK-FIXES-NEXT: observe(Number);
// CHECK-FIXES-NEXT: }
Expand All @@ -104,7 +104,7 @@ void constContainer(const Reversable<int> &Numbers) {
observe(*I);
}
// CHECK-MESSAGES: :[[@LINE-3]]:3: warning: use range-based for loop instead
// CHECK-FIXES-RANGES: for (int Number : std::ranges::reverse_view(Numbers)) {
// CHECK-FIXES-RANGES: for (int Number : std::views::reverse(Numbers)) {
// CHECK-FIXES-CUSTOM: for (int Number : llvm::reverse(Numbers)) {
// CHECK-FIXES-NEXT: observe(Number);
// CHECK-FIXES-NEXT: }
Expand All @@ -113,7 +113,7 @@ void constContainer(const Reversable<int> &Numbers) {
observe(*I);
}
// CHECK-MESSAGES: :[[@LINE-3]]:3: warning: use range-based for loop instead
// CHECK-FIXES-RANGES: for (int Number : std::ranges::reverse_view(Numbers)) {
// CHECK-FIXES-RANGES: for (int Number : std::views::reverse(Numbers)) {
// CHECK-FIXES-CUSTOM: for (int Number : llvm::reverse(Numbers)) {
// CHECK-FIXES-NEXT: observe(Number);
// CHECK-FIXES-NEXT: }
Expand All @@ -122,7 +122,7 @@ void constContainer(const Reversable<int> &Numbers) {
observe(*I);
}
// CHECK-MESSAGES: :[[@LINE-3]]:3: warning: use range-based for loop instead
// CHECK-FIXES-RANGES: for (int Number : std::ranges::reverse_view(Numbers)) {
// CHECK-FIXES-RANGES: for (int Number : std::views::reverse(Numbers)) {
// CHECK-FIXES-CUSTOM: for (int Number : llvm::reverse(Numbers)) {
// CHECK-FIXES-NEXT: observe(Number);
// CHECK-FIXES-NEXT: }
Expand All @@ -141,7 +141,7 @@ void nonConstContainer(Reversable<int> &Numbers) {
mutate(*I);
}
// CHECK-MESSAGES: :[[@LINE-3]]:3: warning: use range-based for loop instead
// CHECK-FIXES-RANGES: for (int & Number : std::ranges::reverse_view(Numbers)) {
// CHECK-FIXES-RANGES: for (int & Number : std::views::reverse(Numbers)) {
// CHECK-FIXES-CUSTOM: for (int & Number : llvm::reverse(Numbers)) {
// CHECK-FIXES-NEXT: mutate(Number);
// CHECK-FIXES-NEXT: }
Expand All @@ -150,7 +150,7 @@ void nonConstContainer(Reversable<int> &Numbers) {
observe(*I);
}
// CHECK-MESSAGES: :[[@LINE-3]]:3: warning: use range-based for loop instead
// CHECK-FIXES-RANGES: for (int Number : std::ranges::reverse_view(Numbers)) {
// CHECK-FIXES-RANGES: for (int Number : std::views::reverse(Numbers)) {
// CHECK-FIXES-CUSTOM: for (int Number : llvm::reverse(Numbers)) {
// CHECK-FIXES-NEXT: observe(Number);
// CHECK-FIXES-NEXT: }
Expand All @@ -159,7 +159,7 @@ void nonConstContainer(Reversable<int> &Numbers) {
mutate(*I);
}
// CHECK-MESSAGES: :[[@LINE-3]]:3: warning: use range-based for loop instead
// CHECK-FIXES-RANGES: for (int & Number : std::ranges::reverse_view(Numbers)) {
// CHECK-FIXES-RANGES: for (int & Number : std::views::reverse(Numbers)) {
// CHECK-FIXES-CUSTOM: for (int & Number : llvm::reverse(Numbers)) {
// CHECK-FIXES-NEXT: mutate(Number);
// CHECK-FIXES-NEXT: }
Expand Down
3 changes: 1 addition & 2 deletions clang-tools-extra/test/clang-tidy/checkers/modernize/use-ranges-pipe.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ void stdLib() {
std::vector<int> I;
std::find(I.rbegin(), I.rend(), 0);
// CHECK-MESSAGES: :[[@LINE-1]]:3: warning: use a ranges version of this algorithm
// CHECK-FIXES-NOPIPE: std::ranges::find(std::ranges::reverse_view(I), 0);
// CHECK-FIXES-NOPIPE: std::ranges::find(std::views::reverse(I), 0);
// CHECK-FIXES-PIPE: std::ranges::find(I | std::views::reverse, 0);

}
8 changes: 4 additions & 4 deletions clang-tools-extra/test/clang-tidy/checkers/modernize/use-ranges.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,19 +94,19 @@ void Reverse(){

std::find(K.rbegin(), K.rend(), std::unique_ptr<int>());
// CHECK-MESSAGES: :[[@LINE-1]]:3: warning: use a ranges version of this algorithm
// CHECK-FIXES: std::ranges::find(std::ranges::reverse_view(K), std::unique_ptr<int>());
// CHECK-FIXES: std::ranges::find(std::views::reverse(K), std::unique_ptr<int>());

std::find(I.rbegin(), I.rend(), 0);
// CHECK-MESSAGES: :[[@LINE-1]]:3: warning: use a ranges version of this algorithm
// CHECK-FIXES: std::ranges::find(std::ranges::reverse_view(I), 0);
// CHECK-FIXES: std::ranges::find(std::views::reverse(I), 0);

std::equal(std::rbegin(I), std::rend(I), J.begin(), J.end());
// CHECK-MESSAGES: :[[@LINE-1]]:3: warning: use a ranges version of this algorithm
// CHECK-FIXES: std::ranges::equal(std::ranges::reverse_view(I), J);
// CHECK-FIXES: std::ranges::equal(std::views::reverse(I), J);

std::equal(I.begin(), I.end(), std::crbegin(J), std::crend(J));
// CHECK-MESSAGES: :[[@LINE-1]]:3: warning: use a ranges version of this algorithm
// CHECK-FIXES: std::ranges::equal(I, std::ranges::reverse_view(J));
// CHECK-FIXES: std::ranges::equal(I, std::views::reverse(J));
}

void Negatives() {
Expand Down