feat(*): step 6 [Ready for review] #15
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aoudiamoncef
force-pushed
the
step-6
branch
3 times, most recently
from
e12a801 to
5ed4868
Compare
loicmathieu
requested changes
Dec 4, 2019
Owner
loicmathieu
left a comment
loicmathieu
left a comment
There was a problem hiding this comment.
Some minor changes requested overall looks good :)
bookmark-service/src/main/java/fr/loicmathieu/bookmarkit/BookmarkResource.java
Outdated
Show resolved
Hide resolved
bookmark-service/src/main/java/fr/loicmathieu/bookmarkit/BookmarkResource.java
Outdated
Show resolved
Hide resolved
Owner
|
@aoudiamoncef I check it and it's OK. |
Contributor
Author
|
@loicmathieu i think that's already done |
Owner
|
@aoudiamoncef Sorry, I'll have a look |
Owner
|
@aoudiamoncef can you rebase on step5? The branch changed a lot. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @loicmathieu,
This is the final branch, we will validate it and at the end of the process, i'll propagate the changes to the other branches. I'll just remove code and push.