DM-23841: Add option to have Mag use calibrated fluxes #358
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, Mag required either a calib object or calib=None, when a default zero-point would be used. Now, since the pipe-analysis parquet tables are writing calibrated fluxes, if we want to compute mags from them, then there needs to be an option for the Mag calculation to have a ZP of one; this allows this if calib=False.
timothydmorton
force-pushed
the
tickets/DM-23841
branch
from
83f2558 to
1e47eea
Compare
morriscb
approved these changes
Mar 16, 2020
Contributor
morriscb
left a comment
morriscb
left a comment
There was a problem hiding this comment.
Looks fine. You may want to look at the LocalPhotometry functors if you need something like this as they apply the local value of the photoCalib to the fluxes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, Mag required either a calib object or calib=None, when a default zero-point would be used. Now, since the pipe-analysis parquet tables are writing calibrated fluxes, if we want to compute mags from them, then there needs to be an option for the Mag calculation to have a ZP of one; this allows this if calib=False.