Retry async query of Profile Manager when it's not ready #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Y_TO_USE response, tends to happen shortly after a device boot while the EMDK is still starting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Retry async whery of Profile Manager when we get the FEATURE_NOT_READY_TO_USE response. Also lengthen the timeout used in the DICommandBaseSettings object - this was way too short. If the timeout callback fires during an async call for the profile, the wait never succeeds.
There's a separate issue with waitForEMDK not covered by this PR. That method looks non-functional. The only times it's called is when initializeEMDK fails to make the getEMDKManager call, but subsequent attempts for the wait method to call initializeEMDK will return immediately because bInitializing is always true in that situation. Even if the wait loop was functional, the really short timeout in DICommandBaseSettings compared to MAX_EMDK_TIMEOUT_IN_MS would shut down everything that the loop is waiting for.